From: David Miller <davem@davemloft.net>
To: borntraeger@de.ibm.com
Cc: cotte@de.ibm.com, herbert@gondor.apana.org.au,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 3/3] Virtio draft IV: the net driver
Date: Wed, 11 Jul 2007 13:44:47 -0700 (PDT) [thread overview]
Message-ID: <20070711.134447.39159166.davem@davemloft.net> (raw)
In-Reply-To: <200707111245.40717.borntraeger@de.ibm.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Date: Wed, 11 Jul 2007 12:45:40 +0200
> Am Mittwoch, 4. Juli 2007 schrieb Rusty Russell:
> > +static void receive_skb(struct net_device *dev, struct sk_buff *skb,
> [...]
> > + netif_rx(skb);
>
> In the NAPI case, we should use netif_receive_skb, no?
NAPI doesn't make sense for virtual devices, my Sun LDOM nework
driver won't use NAPI either.
It's also too cumbersome to use NAPI with the way virtualized
network drivers work (multiple ports, each with an interrupt
source, not just one) until the NAPI split patches are ported
and applied upstream and that won't be for a while.
next prev parent reply other threads:[~2007-07-11 20:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 4:12 [PATCH 1/3] Virtio draft IV Rusty Russell
2007-07-04 4:19 ` [PATCH 2/3] Virtio draft IV: the block driver Rusty Russell
2007-07-04 4:40 ` [PATCH 3/3] Virtio draft IV: the net driver Rusty Russell
2007-07-11 10:28 ` Christian Borntraeger
2007-07-11 11:26 ` Rusty Russell
2007-07-11 11:46 ` Christian Borntraeger
2007-07-12 2:23 ` Rusty Russell
2007-07-11 19:27 ` Caitlin Bestler
2007-07-11 10:45 ` Christian Borntraeger
2007-07-11 11:32 ` Rusty Russell
2007-07-11 20:44 ` David Miller [this message]
2007-07-12 2:21 ` Rusty Russell
2007-07-12 2:26 ` David Miller
2007-07-05 7:32 ` [PATCH 2/3] Virtio draft IV: the block driver Christian Borntraeger
2007-07-06 0:33 ` Rusty Russell
2007-07-23 11:13 ` Christian Borntraeger
2007-07-24 3:02 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711.134447.39159166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).