From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 3/3] Virtio draft IV: the net driver Date: Wed, 11 Jul 2007 13:44:47 -0700 (PDT) Message-ID: <20070711.134447.39159166.davem@davemloft.net> References: <1183522765.6110.40.camel@localhost.localdomain> <1183524053.6110.45.camel@localhost.localdomain> <200707111245.40717.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200707111245.40717.borntraeger@de.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: borntraeger@de.ibm.com Cc: cotte@de.ibm.com, herbert@gondor.apana.org.au, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org From: Christian Borntraeger Date: Wed, 11 Jul 2007 12:45:40 +0200 > Am Mittwoch, 4. Juli 2007 schrieb Rusty Russell: > > +static void receive_skb(struct net_device *dev, struct sk_buff *skb, > [...] > > + netif_rx(skb); > > In the NAPI case, we should use netif_receive_skb, no? NAPI doesn't make sense for virtual devices, my Sun LDOM nework driver won't use NAPI either. It's also too cumbersome to use NAPI with the way virtualized network drivers work (multiple ports, each with an interrupt source, not just one) until the NAPI split patches are ported and applied upstream and that won't be for a while.