Re: [uml-devel] [PATCH 1/5] um/... convert #include "linux/..." to #include <linux/...>

From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Miklos Szeredi <mszeredi@suse.cz>,
	Maxim Krasnyansky <maxk@qualcomm.com>,
	Jeff Dike <jdike@karaya.com>,
	kernel-janitors@vger.kernel.org, Jason Lunz <lunz@falooley.org>,
	Jan Beulich <jbeulich@novell.com>,
	vtun@office.satix.net, Jens Axboe <jens.axboe@oracle.com>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>,
	Davide Brini <davide.brini@unibo.it>,
	Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@elte.hu>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jeff Dike <jdike@addtoit.com>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	Chris Wright <chrisw@sous-sol.org>,
	user-mode-linux-user@lists.sourceforge.net,
	Jeff Dike <jdike@linux.intel.com>,
	Arnaldo
Subject: Re: [uml-devel] [PATCH 1/5] um/... convert #include "linux/..." to #include	 <linux/...>
Date: Tue, 21 Aug 2007 19:09:17 +0200	[thread overview]
Message-ID: <200708211909.23027.blaisorblade@yahoo.it> (raw)
In-Reply-To: <1187561903.4200.138.camel@localhost>


[-- Attachment #1.1: Type: text/plain, Size: 1126 bytes --]

On lunedì 20 agosto 2007, Joe Perches wrote:
> (untested)
>
> There are several files that
> #include "linux/file" not #include <linux/file>
> #include "asm/file" not #include <asm/file>
>
> Here's a little script that converts them:
>
> egrep -i -r -l --include=*.[ch] \
> "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
>
> | xargs sed -i -e
> | 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/
> |#include <\1\/\2>/g'
>
> Signed-off-by: Joe Perches <joe@perches.com>

Wait, this patch may or may not be sane (Jeff will tell more I guess). Since 
we use two different sets of headers (the host ones from userspace and the 
guest ones from Linux), this peculiar style has been used till now to make 
clear the difference (#include <file> is used for host headers) - at least 
that's what I think (I've never asked to Jeff, but I silently deduced this 
and followed this practice).
-- 
"Doh!" (cit.), I've made another another mistake!
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 184 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization