From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] Remove pagesize parameter from vring_init/vring_size Date: Thu, 15 Nov 2007 09:19:55 +1100 Message-ID: <200711150919.55752.rusty@rustcorp.com.au> References: <11950564033349-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <11950564033349-git-send-email-aliguori@us.ibm.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Anthony Liguori Cc: virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Thursday 15 November 2007 03:06:43 Anthony Liguori wrote: > The PAGE_SIZE constant should be used instead of taking an extra parameter. > Moreover, once we use PAGE_SIZE, we can use PAGE_ALIGN() instead of having > it open coded. Unfortunately this is exposed to userspace. I should probably add a comment. Cheers, Rusty.