From: Ingo Molnar <mingo@elte.hu>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: ehabkost@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, chrisw@sous-sol.org,
anthony@codemonkey.ws, hpa@zytor.com, akpm@linux-foundation.org,
tglx@linutronix.de, roland@redhat.com, ak@suse.de
Subject: Re: [PATCH 21/21] [PATCH] finish processor.h integration
Date: Tue, 18 Dec 2007 16:43:19 +0100 [thread overview]
Message-ID: <20071218154319.GA11369@elte.hu> (raw)
In-Reply-To: <4767CFC5.3010703@redhat.com>
* Glauber de Oliveira Costa <gcosta@redhat.com> wrote:
>> here the problem is apparently caused by your patch, a careless
>> 'unification' of include file sections. 32-bit had this:
>
> Point is this patches do unification, but they are not just that, as
> you can see. I am attempting to cleanup headers that appears not to be
> used, [...]
do cleanups and unification in _separate_ patches. We do not want to
change a SINGLE LINE OF SOURCE CODE in a patch that says "unify" and
moves a block of code from one file to another, ok? If you see some
obvious cleanups do it in pre or post patches (whichever looks more
logical). That makes it totally bisectable and i can drop the bogus
cleanup patch instead of having to drop a full unification patch.
Ingo
next prev parent reply other threads:[~2007-12-18 15:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11979319641796-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 1/21] move tsc definitions to were they belong Glauber de Oliveira Costa
2007-12-17 22:52 ` [PATCH 2/21] [PATCH] get rid of _MASK flags Glauber de Oliveira Costa
[not found] ` <11979319763641-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 3/21] [PATCH] move desc_empty to where they belong Glauber de Oliveira Costa
2007-12-17 22:52 ` [PATCH 4/21] [PATCH] move load_cr3 to a common place Glauber de Oliveira Costa
[not found] ` <11979319853319-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 5/21] [PATCH] unify paravirt pieces of processor.h Glauber de Oliveira Costa
[not found] ` <11979319903443-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 6/21] [PATCH] move the definition of set_iopl_mask to common header Glauber de Oliveira Costa
[not found] ` <11979319953427-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 7/21] [PATCH] unify common parts of processor.h Glauber de Oliveira Costa
[not found] ` <11979320011968-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 8/21] [PATCH] unify current_text_addr Glauber de Oliveira Costa
[not found] ` <1197932006634-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 9/21] [PATCH] unify tss_struct Glauber de Oliveira Costa
[not found] ` <11979320114180-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 10/21] [PATCH] provide x86_64 with a load_sp0 function Glauber de Oliveira Costa
[not found] ` <11979320163651-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 11/21] [PATCH] unify thread struct Glauber de Oliveira Costa
[not found] ` <11979320211287-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 12/21] [PATCH] unify TASK_ALIGN definitions Glauber de Oliveira Costa
[not found] ` <11979320252102-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 13/21] [PATCH] change bitwise operations to get a void parameter Glauber de Oliveira Costa
[not found] ` <11979320302030-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 14/21] [PATCH] unify x86_cpuinfo struct Glauber de Oliveira Costa
[not found] ` <11979320354186-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 15/21] [PATCH] remove legacy stuff from processor_64.h Glauber de Oliveira Costa
[not found] ` <11979320401316-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 16/21] [PATCH] unify mm_segment_t definition Glauber de Oliveira Costa
[not found] ` <11979320451308-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 17/21] [PATCH] move definitions to processor.h Glauber de Oliveira Costa
[not found] ` <1197932050948-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 18/21] [PATCH] unify prefetch operations Glauber de Oliveira Costa
[not found] ` <11979320551036-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 19/21] [PATCH] unify asm nops Glauber de Oliveira Costa
[not found] ` <11979320603229-git-send-email! -gcosta@redhat.com>
[not found] ` <11979320603229-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 20/21] [PATCH] move i387 definitions to processor.h Glauber de Oliveira Costa
[not found] ` <11979320653161-git-send-email-gcosta@redhat.com>
2007-12-17 22:52 ` [PATCH 21/21] [PATCH] finish processor.h integration Glauber de Oliveira Costa
[not found] ` <11979320693300-git-send-email-gcosta@redhat.com>
2007-12-18 13:19 ` Ingo Molnar
[not found] ` <20071218131932.GA9457@elte.hu>
2007-12-18 13:38 ` Ingo Molnar
[not found] ` <20071218133818.GA9941@elte.hu>
2007-12-18 13:40 ` Ingo Molnar
2007-12-18 13:48 ` Glauber de Oliveira Costa
[not found] ` <20071218134018.GA13193@elte.hu>
2007-12-18 13:49 ` Glauber de Oliveira Costa
2007-12-18 15:44 ` Ingo Molnar
[not found] ` <4767CFC5.3010703@redhat.com>
2007-12-18 15:43 ` Ingo Molnar [this message]
2007-12-18 5:18 ` [PATCH 13/21] [PATCH] change bitwise operations to get a void parameter Rusty Russell
[not found] ` <200712181618.43852.rusty@rustcorp.com.au>
2007-12-18 5:38 ` H. Peter Anvin
2007-12-18 12:40 ` Glauber de Oliveira Costa
[not found] ` <5d6222a80712180440l72faa8fere9588ea6894cf1cb@mail.gmail.com>
2007-12-18 17:26 ` H. Peter Anvin
2007-12-18 11:45 ` [PATCH 7/21] [PATCH] unify common parts of processor.h Ingo Molnar
[not found] ` <20071218114504.GA22832@elte.hu>
2007-12-18 12:05 ` Glauber de Oliveira Costa
[not found] ` <4767B78A.5030903@redhat.com>
2007-12-18 14:00 ` Ingo Molnar
2007-12-18 5:14 ` [PATCH 3/21] [PATCH] move desc_empty to where they belong Rusty Russell
[not found] ` <200712181614.37890.rusty@rustcorp.com.au>
2007-12-18 12:03 ` Glauber de Oliveira Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218154319.GA11369@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=ehabkost@redhat.com \
--cc=gcosta@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).