From: Chris Wright <chrisw@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Chris Wright <chrisw@sous-sol.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Gregory Haskins <ghaskins@novell.com>,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <srostedt@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"William L. Irwin" <sparclinux@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation
Date: Thu, 3 Jan 2008 10:16:51 -0800 [thread overview]
Message-ID: <20080103181651.GC3627@sequoia.sous-sol.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0801030849180.1468@gandalf.stny.rr.com>
* Steven Rostedt (rostedt@goodmis.org) wrote:
> Hmm, I know paravirt-ops had an issue with mcount in the RT tree. I can't
> remember the exact issues, but it did have something to do with the way
> parameters were passed in.
>
> Chris, do you remember what the issues were?
Yes, paravirt ops have a well-specified calling convention (register
based). There was a cleanup that Andi did that caused the problem
because it removed all the "fastcall" annotations since -mregparm=3
is now always on for i386. Since MCOUNT disables REGPARM the calling
convention changes (caller pushes to stack, callee expects register)
chaos ensues. I sent a patch to fix that quite some months back, but
it went stale and I neglected to update it. Would you like me to dig
it up refresh and resend?
thanks,
-chris
next prev parent reply other threads:[~2008-01-03 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080103071609.478486470@goodmis.org>
[not found] ` <20080103072226.776141236@goodmis.org>
[not found] ` <20080103092104.GE10813@elte.hu>
2008-01-03 13:58 ` [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation Steven Rostedt
[not found] ` <Pine.LNX.4.58.0801030849180.1468@gandalf.stny.rr.com>
2008-01-03 18:16 ` Chris Wright [this message]
2008-01-03 19:15 ` Steven Rostedt
[not found] ` <Pine.LNX.4.58.0801031413410.5746@gandalf.stny.rr.com>
2008-01-03 19:17 ` Chris Wright
2008-01-03 19:18 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080103181651.GC3627@sequoia.sous-sol.org \
--to=chrisw@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=ghaskins@novell.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
--cc=srostedt@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox