* [PATCH] virtio_rng: adopt driver to newest virtio code
@ 2008-01-14 15:51 Christian Borntraeger
2008-01-15 0:01 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Christian Borntraeger @ 2008-01-14 15:51 UTC (permalink / raw)
To: Rusty Russell; +Cc: virtualization
Rusty,
This patch changes the virtio_rng to a callback without a return value.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
drivers/char/hw_random/virtio-rng.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: kvm/drivers/char/hw_random/virtio-rng.c
===================================================================
--- kvm.orig/drivers/char/hw_random/virtio-rng.c
+++ kvm/drivers/char/hw_random/virtio-rng.c
@@ -27,13 +27,12 @@ static struct virtqueue *vq;
static u32 random_data;
static bool have_data;
-static bool random_recv_done(struct virtqueue *vq)
+static void random_recv_done(struct virtqueue *vq)
{
have_data = true;
- /* Don't suppress callbacks: there can't be any more since we
+ /* No need to call disable_cb: there can't be any more since we
* have used up the only buffer. */
- return true;
}
static void register_buffer(void)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_rng: adopt driver to newest virtio code
2008-01-14 15:51 [PATCH] virtio_rng: adopt driver to newest virtio code Christian Borntraeger
@ 2008-01-15 0:01 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2008-01-15 0:01 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: virtualization
On Tuesday 15 January 2008 02:51:47 Christian Borntraeger wrote:
> Rusty,
>
> This patch changes the virtio_rng to a callback without a return value.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Thanks, applied.
BTW, virtio-rng was pretty much untested, so no huge surprise it has bugs.
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-15 0:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-14 15:51 [PATCH] virtio_rng: adopt driver to newest virtio code Christian Borntraeger
2008-01-15 0:01 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).