Re: [PATCH 4/5] [PATCH] introduce paravirt helpers

[Ravikiran Thirumalai <kiran@scalemp.com>]

On Sun, Feb 17, 2008 at 06:56:56PM -0200, Glauber Costa wrote:
>On Feb 17, 2008 4:05 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> * Glauber Costa <gcosta@redhat.com> wrote:
>>
>> >  config X86_VSMP
>> >       bool "Support for ScaleMP vSMP"
>> >       depends on X86_64 && PCI
>> > -      help
>> > +     select PARAVIRT
>> > +     help
>>
>> hm, what's the idea here?
>
>guys from scalemp can probably give a better picture if needed,
>but in a nutshell, there are two aspects involved with the vsmp
>support. The first one
>is special L1 alignments, and the second, specialized irq handling routines.
>
>Only the second one is paravirt in itself, and are the ones addressed
>in this patch.
>The specialized routines now goes through paravirt ops. So when using
>a vsmp machine,
>paravirt has to be selected, in order to enable such functions.

Thanks Glauber.  Well put.

That said, future revs of vSMP will have the ability to work optimally even
without the paravirtualized irq ops.  This is an upcoming feature, and did not
exist when we tested the paravirt ops 2-3 months ago.  So, it will be
better, now, not to select PARAVIRT while selecting X86_VSMP.  Then,
CONFIG_VSMP will just select the cacheline padding to be used and PARAVIRT
will be needed if irq operations need to be paravirtualized.

I shall submit a patch to that effect.

Thanks,
Kiran