From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization@lists.linux-foundation.org
Cc: virtualization@lists.osdl.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] virtio: remove overzealous BUG_ON.
Date: Tue, 8 Apr 2008 06:09:12 +1000 [thread overview]
Message-ID: <200804080609.12891.rusty@rustcorp.com.au> (raw)
In-Reply-To: <47FA26A0.3020701@codemonkey.ws>
On Monday 07 April 2008 23:50:24 Anthony Liguori wrote:
> Rusty Russell wrote:
> > The 'disable_cb' callback is designed as an optimization to tell the host
> > we don't need callbacks now. As it is not reliable, the debug check is
> > overzealous: it can happen on two CPUs at the same time. Document this.
> >
> > Even if it were reliable, the virtio_net driver doesn't disable
> > callbacks on transmit so the START_USE/END_USE debugging reentrance
> > protection can be easily tripped even on UP.
> >
> > Thanks to Balaji Rao for the bug report and testing.
>
> I think the printk() in start_xmit should be removed too (or at least
> rate limited).
Yep, please send patch. I'm about to jump on a plane, so consider this a
pre-canned ack.
Thanks,
Rusty.
prev parent reply other threads:[~2008-04-07 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 4:30 [PATCH] virtio: remove overzealous BUG_ON Rusty Russell
2008-04-07 13:50 ` Anthony Liguori
2008-04-07 13:50 ` Anthony Liguori
[not found] ` <47FA26A0.3020701@codemonkey.ws>
2008-04-07 20:09 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804080609.12891.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).