From: Rusty Russell <rusty@rustcorp.com.au>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Max Krasnyansky <maxk@qualcomm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.
Date: Sun, 20 Apr 2008 02:45:59 +1000 [thread overview]
Message-ID: <200804200246.00282.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080419163322.GA17089@2ka.mipt.ru>
On Sunday 20 April 2008 02:33:22 Evgeniy Polyakov wrote:
> On Sun, Apr 20, 2008 at 02:05:31AM +1000, Rusty Russell
(rusty@rustcorp.com.au) wrote:
> > There are two reasons not to grab the lock. It turns out that if we
> > tried to lock here, we'd deadlock, since the callbacks are called under
> > the lock. Secondly, it's possible to implement an atomic
> > vring_used_buffer variant, which could fail: this would avoid using the
> > thread most of the time.
>
> Yep, I decided that too. But it limits its usage to tun only or any
> other system where only single thread picks up results, so no generic
> userspace ring buffers?
I don't think so, it just externalizes the locking. The mutex protects the
attaching and detaching of the ops structure, some other lock or code
protects simultenous kernel ring accesses.
Cheers,
Rusty.
prev parent reply other threads:[~2008-04-19 16:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804181433.48488.rusty@rustcorp.com.au>
2008-04-18 4:35 ` [PATCH 1/5] virtio: put last_used and last_avail index into ring itself Rusty Russell
[not found] ` <200804181435.21214.rusty@rustcorp.com.au>
2008-04-18 4:39 ` [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface Rusty Russell
[not found] ` <200804181439.49051.rusty@rustcorp.com.au>
2008-04-18 4:41 ` [PATCH 3/5] /dev/vring limit and base ioctls Rusty Russell
[not found] ` <200804181441.10499.rusty@rustcorp.com.au>
2008-04-18 4:42 ` [PATCH 4/5] tun: vringfd receive support Rusty Russell
[not found] ` <200804181442.17251.rusty@rustcorp.com.au>
2008-04-18 4:43 ` [PATCH 5/5] tun: vringfd xmit support Rusty Russell
2008-04-18 4:43 ` Rusty Russell
[not found] ` <200804181443.24812.rusty@rustcorp.com.au>
2008-04-18 11:31 ` Andrew Morton
2008-04-18 15:15 ` Rusty Russell
2008-04-18 16:24 ` Ray Lee
2008-04-18 19:06 ` Andrew Morton
2008-04-19 14:41 ` Rusty Russell
[not found] ` <200804200041.43969.rusty@rustcorp.com.au>
2008-04-19 17:51 ` Andrew Morton
2008-04-19 1:54 ` Andrew Morton
2008-04-18 11:46 ` pradeep singh rautela
2008-04-18 14:25 ` Ray Lee
2008-04-18 18:01 ` pradeep singh rautela
2008-04-18 11:18 ` [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface Andrew Morton
[not found] ` <20080418041846.db15150b.akpm@linux-foundation.org>
2008-04-18 14:32 ` Rusty Russell
2008-04-18 18:59 ` Andrew Morton
2008-04-18 19:38 ` Michael Kerrisk
2008-04-19 16:41 ` Rusty Russell
[not found] ` <200804200241.14722.rusty@rustcorp.com.au>
2008-04-20 0:16 ` David Miller
2008-04-19 15:02 ` Jonathan Corbet
2008-04-19 10:22 ` Evgeniy Polyakov
[not found] ` <20080419102214.GA21952@2ka.mipt.ru>
2008-04-19 16:05 ` Rusty Russell
2008-04-19 16:33 ` Evgeniy Polyakov
[not found] ` <20080419163322.GA17089@2ka.mipt.ru>
2008-04-19 16:45 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804200246.00282.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).