From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kvm-devel@lists.sourceforge.net,
Hollis Blanchard <hollisb@us.ibm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.
Date: Thu, 24 Apr 2008 01:53:41 +1000 [thread overview]
Message-ID: <200804240153.42251.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200804231255.50248.borntraeger@de.ibm.com>
On Wednesday 23 April 2008 20:55:50 Christian Borntraeger wrote:
> Am Dienstag, 22. April 2008 schrieb Rusty Russell:
> [...]
>
> > diff -r a098f19a6da5 include/linux/virtio_config.h
> > --- a/include/linux/virtio_config.h Sun Apr 20 14:41:02 2008 +1000
> > +++ b/include/linux/virtio_config.h Sun Apr 20 15:07:45 2008 +1000
> > @@ -16,7 +16,7 @@
> > #define VIRTIO_CONFIG_S_FAILED 0x80
> >
> > #ifdef __KERNEL__
> > -struct virtio_device;
> > +#include <linux/virtio.h>
>
> I just realized, that this breaks make headers_check as we dont export
> virtio.h (and we dont want to export it as it relies on scatterlist.h).
It's under #ifdef __KERNEL__ though?
Cheers,
Rusty.
prev parent reply other threads:[~2008-04-23 15:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804221357.34571.rusty@rustcorp.com.au>
2008-04-22 7:44 ` [RFC PATCH] virtio: change config to guest endian Christian Borntraeger
2008-04-22 11:22 ` [kvm-devel] " Avi Kivity
[not found] ` <480DCA88.4010407@qumranet.com>
2008-04-22 14:31 ` Rusty Russell
2008-04-22 16:21 ` Hollis Blanchard
[not found] ` <200804230031.35760.rusty@rustcorp.com.au>
2008-04-22 20:29 ` Hollis Blanchard
2008-04-22 21:05 ` Rusty Russell
[not found] ` <200804230705.38495.rusty@rustcorp.com.au>
2008-04-22 22:08 ` Hollis Blanchard
[not found] ` <200804221708.39452.hollisb@us.ibm.com>
2008-04-22 22:13 ` Anthony Liguori
[not found] ` <480E62ED.2090004@codemonkey.ws>
2008-04-22 22:33 ` Hollis Blanchard
2008-04-22 23:53 ` Hollis Blanchard
[not found] ` <200804220944.08568.borntraeger@de.ibm.com>
2008-04-22 14:40 ` Rusty Russell
2008-04-23 10:55 ` [kvm-devel] " Christian Borntraeger
[not found] ` <200804231255.50248.borntraeger@de.ibm.com>
2008-04-23 12:38 ` Avi Kivity
[not found] ` <480F2DD5.7080007@qumranet.com>
2008-04-23 12:47 ` Christian Borntraeger
2008-04-23 15:53 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804240153.42251.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=borntraeger@de.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).