From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel <xen-devel@lists.xensource.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
kvm-devel <kvm-devel@lists.sourceforge.net>,
benh@kernel.crashing.org, x86@kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Hugh Dickins <hugh@veritas.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction
Date: Thu, 19 Jun 2008 18:47:08 +0200 [thread overview]
Message-ID: <20080619164708.GA32190@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.10.0806190928100.2907@woody.linux-foundation.org>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, 19 Jun 2008, Ingo Molnar wrote:
> >
> > Below is the commit, it needed a small amount of massaging to apply the
> > void * -> unsigned long * change in the x86/bitops topic.
>
> Well, that's your bug right there.
>
> The macros very much depended on the pointers being "void *", due to
> the pointer arithmetic (which is a gcc extension that we use
> extensively - "void *" arithmetic works as if it was a byte pointer).
duh, yeah - of course. Will retry with that fixed :)
Ingo
next prev parent reply other threads:[~2008-06-19 16:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 11:29 [PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write abstraction (take 2) Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction Jeremy Fitzhardinge
2008-06-16 17:29 ` Linus Torvalds
2008-06-16 18:13 ` Hugh Dickins
2008-06-16 18:49 ` Ingo Molnar
2008-06-18 23:23 ` Benjamin Herrenschmidt
2008-06-18 23:59 ` Jeremy Fitzhardinge
2008-06-19 0:15 ` Jeremy Fitzhardinge
2008-06-19 0:24 ` Linus Torvalds
2008-06-19 0:37 ` Jeremy Fitzhardinge
2008-06-19 0:49 ` Linus Torvalds
2008-06-19 4:03 ` Linus Torvalds
2008-06-19 11:58 ` Ingo Molnar
2008-06-19 12:03 ` Ingo Molnar
2008-06-19 12:20 ` Akinobu Mita
2008-06-19 16:30 ` Linus Torvalds
2008-06-19 16:47 ` Ingo Molnar [this message]
2008-06-20 10:10 ` Ingo Molnar
2008-06-20 19:06 ` Jeremy Fitzhardinge
2008-06-20 19:15 ` Linus Torvalds
2008-06-20 19:56 ` Ingo Molnar
2008-06-20 20:03 ` Linus Torvalds
2008-06-20 20:16 ` Jeremy Fitzhardinge
2008-06-20 20:22 ` Jeremy Fitzhardinge
2008-06-21 6:06 ` Ingo Molnar
2008-06-20 20:05 ` Jeremy Fitzhardinge
2008-06-19 0:39 ` Benjamin Herrenschmidt
2008-06-19 5:03 ` Jeremy Fitzhardinge
2008-06-19 7:20 ` Benjamin Herrenschmidt
2008-06-19 17:57 ` Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_start/commit Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 3 of 4] xen: implement ptep_modify_prot_start/commit Jeremy Fitzhardinge
2008-06-16 11:30 ` [PATCH 4 of 4] xen: add mechanism to extend existing multicalls Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2008-05-31 0:04 [PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write abstraction (take 2) Jeremy Fitzhardinge
2008-05-31 0:04 ` [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction Jeremy Fitzhardinge
2008-06-02 11:13 ` Ingo Molnar
2008-06-02 11:57 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080619164708.GA32190@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=benh@kernel.crashing.org \
--cc=hugh@veritas.com \
--cc=jeremy@goop.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.osdl.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).