From: David Miller <davem@davemloft.net>
To: maxk@qualcomm.com
Cc: rusty@rustcorp.com.au, markmc@redhat.com, netdev@vger.kernel.org,
virtualization@lists.osdl.org
Subject: Re: [PATCH 1/1] tun: TUNGETIFF interface to query name and flags
Date: Fri, 15 Aug 2008 15:10:09 -0700 (PDT) [thread overview]
Message-ID: <20080815.151009.157459097.davem@davemloft.net> (raw)
In-Reply-To: <48A5C433.7030002@qualcomm.com>
From: Max Krasnyansky <maxk@qualcomm.com>
Date: Fri, 15 Aug 2008 11:00:19 -0700
> Rusty Russell wrote:
> > On Thursday 14 August 2008 00:30:16 Mark McLoughlin wrote:
> >> A very simple approach is attached; I did consider doing a TUNGETFLAGS
> >> that would return tun->flags, but I think it's nicer to have a companion
> >> to TUNGETIFF since it also allows one to query the interface name from
> >> the file descriptor.
> >
> > This seems really sensible to me.
> >
> > If Max acks it, I'd say Dave should merge it.
>
> Makes perfect sense to me.
> Definitely Ack. It has zero impact on existing user and I'd be ok if this goes
> in during .27-rc series.
I've applied Mark's patch, thanks.
prev parent reply other threads:[~2008-08-15 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 14:30 [PATCH 1/1] tun: TUNGETIFF interface to query name and flags Mark McLoughlin
2008-08-14 1:58 ` Rusty Russell
2008-08-15 14:02 ` Mark McLoughlin
2008-08-15 18:10 ` Max Krasnyansky
2008-08-15 18:00 ` Max Krasnyansky
2008-08-15 22:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815.151009.157459097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=markmc@redhat.com \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).