From: Rusty Russell <rusty@rustcorp.com.au>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_balloon: fix towards_target when deflating balloon
Date: Tue, 19 Aug 2008 11:22:54 +1000 [thread overview]
Message-ID: <200808191122.54845.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1219097731-1224-1-git-send-email-aliguori@us.ibm.com>
On Tuesday 19 August 2008 08:15:31 Anthony Liguori wrote:
> - return v - vb->num_pages;
> + if (v < vb->num_pages)
> + return -(s64)(vb->num_pages - v);
> + else
> + return v - vb->num_pages;
With all due respect, WTF?
Did you mean:
return (s64)v - vb->num_pages;
I'm really amazed this bug got this far though...
Rusty.
next prev parent reply other threads:[~2008-08-19 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1219097731-1224-1-git-send-email-aliguori@us.ibm.com>
2008-08-19 0:42 ` [PATCH] virtio_balloon: fix towards_target when deflating balloon Linus Torvalds
[not found] ` <alpine.LFD.1.10.0808181740500.3324@nehalem.linux-foundation.org>
2008-08-19 1:09 ` Anthony Liguori
[not found] ` <48AA1D5E.5050405@us.ibm.com>
2008-08-19 4:17 ` Linus Torvalds
2008-08-19 1:22 ` Rusty Russell [this message]
2008-08-18 22:15 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808191122.54845.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).