From: Rusty Russell <rusty@rustcorp.com.au>
To: Mark McLoughlin <markmc@redhat.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org
Subject: Re: [PATCH 1/2] virtio_net: Recycle some more rx buffer pages
Date: Thu, 16 Oct 2008 16:08:53 +1100 [thread overview]
Message-ID: <200810161608.54017.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1223494499-18732-1-git-send-email-markmc@redhat.com>
On Thursday 09 October 2008 06:34:58 Mark McLoughlin wrote:
> Each time we re-fill the recv queue with buffers, we allocate
> one too many skbs and free it again when adding fails. We should
> recycle the pages allocated in this case.
>
> A previous version of this patch made trim_pages() trim trailing
> unused pages from skbs with some paged data, but this actually
> caused a barely measurable slowdown.
Yes, I noticed a similar effect. Not quite sure why though.
Applied.
Thanks!
Rusty.
prev parent reply other threads:[~2008-10-16 5:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 19:34 [PATCH 1/2] virtio_net: Recycle some more rx buffer pages Mark McLoughlin
2008-10-08 19:34 ` [PATCH 2/2] virtio_net: Improve the recv buffer allocation scheme Mark McLoughlin
2008-10-09 0:55 ` Rusty Russell
2008-10-09 15:30 ` Herbert Xu
2008-10-09 17:40 ` Mark McLoughlin
2008-10-09 19:26 ` Anthony Liguori
2008-10-10 8:30 ` Mark McLoughlin
2008-10-16 9:15 ` Rusty Russell
2008-10-10 12:56 ` Mark McLoughlin
2008-10-16 4:43 ` Rusty Russell
2008-10-09 15:35 ` Chris Wright
2008-10-16 5:08 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810161608.54017.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).