From: Rusty Russell <rusty@rustcorp.com.au>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
Anthony Liguori <aliguori@us.ibm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC] virtio: use QUEUE_FLAG_CLUSTER in virtio_blk
Date: Mon, 17 Nov 2008 17:22:43 +1030 [thread overview]
Message-ID: <200811171722.43792.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081114093023.GQ26778@kernel.dk>
On Friday 14 November 2008 20:00:23 Jens Axboe wrote:
> Queue clustering is on by default though when you allocate your queue,
> so I'm surprised you see a difference by doing:
>
> + /* Gather adjacent buffers to minimize sg length. */
> + queue_flag_set(QUEUE_FLAG_CLUSTER, vblk->disk->queue);
>
> did test_bit(QUEUE_FLAG_CLUSTER, &vblk->disk->queue->queue_flags) really
> return 0 before?
Apparently not. My results must be noise :(
However, it made me look harder at the behaviour of the driver. I have two
other enhancement patches while I'll send now, but I still only see sgs of 116
elements.
Thanks for the clue donation,
Rusty.
next parent reply other threads:[~2008-11-17 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200811141215.33950.rusty@rustcorp.com.au>
[not found] ` <20081114093023.GQ26778@kernel.dk>
2008-11-17 6:52 ` Rusty Russell [this message]
2008-11-17 6:54 ` [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite Rusty Russell
2008-11-17 7:04 ` [PATCH 2/2] virtio: block: dynamic maximum segments Rusty Russell
2008-11-26 17:42 ` [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite Chris Wright
2008-11-27 13:00 ` Rusty Russell
2008-11-27 13:04 ` Jens Axboe
2008-12-03 18:43 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811171722.43792.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).