From: Jens Axboe <jens.axboe@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Chris Wright <chrisw@sous-sol.org>,
kvm-devel <kvm-devel@lists.sourceforge.net>,
Anthony Liguori <aliguori@us.ibm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite.
Date: Thu, 27 Nov 2008 14:04:10 +0100 [thread overview]
Message-ID: <20081127130410.GD22752@kernel.dk> (raw)
In-Reply-To: <200811272330.03308.rusty@rustcorp.com.au>
On Thu, Nov 27 2008, Rusty Russell wrote:
> On Thursday 27 November 2008 04:12:25 Chris Wright wrote:
> > * Rusty Russell (rusty@rustcorp.com.au) wrote:
> > > + /* No real sector limit. */
> > > + blk_queue_max_sectors(vblk->disk->queue, -1U);
> > > +
> >
> > Is that actually legitimate? I think it'd still work out, but seems
> > odd, e.g. all the spots that do:
> >
> > q->max_hw_sectors << 9
> >
> > will just toss the upper bits...
>
> I think this just indicates that *my driver* doesn't have an issue
> with large numbers of sectors. The block layer may well...
We should probably just truncate insanely large values like -1 to
something sane. For the above case we already do trunc it to 1MB, as
it's the soft IO size. The segment size is already in bytes, so in fact
everything already looks fine.
--
Jens Axboe
next prev parent reply other threads:[~2008-11-27 13:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200811141215.33950.rusty@rustcorp.com.au>
[not found] ` <20081114093023.GQ26778@kernel.dk>
2008-11-17 6:52 ` [PATCH RFC] virtio: use QUEUE_FLAG_CLUSTER in virtio_blk Rusty Russell
2008-11-17 6:54 ` [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite Rusty Russell
2008-11-17 7:04 ` [PATCH 2/2] virtio: block: dynamic maximum segments Rusty Russell
2008-11-26 17:42 ` [PATCH 1/2] virtio: block: set max_segment_size and max_sectors to infinite Chris Wright
2008-11-27 13:00 ` Rusty Russell
2008-11-27 13:04 ` Jens Axboe [this message]
2008-12-03 18:43 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127130410.GD22752@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=aliguori@us.ibm.com \
--cc=chrisw@sous-sol.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).