From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 5/6] kvm-s390: use register_virtio_root_device() Date: Thu, 11 Dec 2008 13:49:22 +0100 Message-ID: <20081211134922.71d6d811@gondolin> References: <1228931096.5384.63.camel@blaa> <1228931139-12956-4-git-send-email-markmc@redhat.com> <1228931139-12956-5-git-send-email-markmc@redhat.com> <200812111005.49597.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200812111005.49597.borntraeger@de.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Christian Borntraeger Cc: Mark McLoughlin , Anthony Liguori , Kay Sievers , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Greg KH List-Id: virtualization@lists.linuxfoundation.org On Thu, 11 Dec 2008 10:05:49 +0100, Christian Borntraeger wrote: > Am Mittwoch, 10. Dezember 2008 schrieb Mark McLoughlin: > > This is basically a no-op change, since it does exactly the > > same thing as s390_root_dev_register() when the caller isn't > > a module. > > Ok, I gave it a short test and it seems to work. > Some comments: I agree with your comment in patch0, that a generic > device_register_root() function might be useful. Indeed, if this is a simple replacement, we want a generic function. I'll take a look at the patches. > > > --- a/drivers/s390/kvm/kvm_virtio.c > > +++ b/drivers/s390/kvm/kvm_virtio.c > [...] > > - kvm_root = s390_root_dev_register("kvm_s390"); > > + kvm_root = register_virtio_root_device("kvm_s390"); > [...] > > - s390_root_dev_unregister(kvm_root); > > + unregister_virtio_root_device(kvm_root); > > You can now remove the include