* virtio-balloon: check for freezer in kthread loop
@ 2009-04-17 0:14 Marcelo Tosatti
2009-04-19 13:44 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Marcelo Tosatti @ 2009-04-17 0:14 UTC (permalink / raw)
To: Rusty Russell; +Cc: virtualization
Break out of wait_event_interruptible() if freezing has been requested,
in the vballoon thread. Without this change vballoon refuses to stop and
the system can't suspend.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 5926826..9c76a06 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -190,7 +190,8 @@ static int balloon(void *_vballoon)
try_to_freeze();
wait_event_interruptible(vb->config_change,
(diff = towards_target(vb)) != 0
- || kthread_should_stop());
+ || kthread_should_stop()
+ || freezing(current));
if (diff > 0)
fill_balloon(vb, diff);
else if (diff < 0)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: virtio-balloon: check for freezer in kthread loop
2009-04-17 0:14 virtio-balloon: check for freezer in kthread loop Marcelo Tosatti
@ 2009-04-19 13:44 ` Rusty Russell
2009-04-19 14:00 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2009-04-19 13:44 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: virtualization
On Fri, 17 Apr 2009 09:44:04 am Marcelo Tosatti wrote:
>
> Break out of wait_event_interruptible() if freezing has been requested,
> in the vballoon thread. Without this change vballoon refuses to stop and
> the system can't suspend.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
-stable too, yeah?
Applied,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: virtio-balloon: check for freezer in kthread loop
2009-04-19 13:44 ` Rusty Russell
@ 2009-04-19 14:00 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2009-04-19 14:00 UTC (permalink / raw)
To: Rusty Russell; +Cc: virtualization
On Sun, Apr 19, 2009 at 11:14:12PM +0930, Rusty Russell wrote:
> On Fri, 17 Apr 2009 09:44:04 am Marcelo Tosatti wrote:
> >
> > Break out of wait_event_interruptible() if freezing has been requested,
> > in the vballoon thread. Without this change vballoon refuses to stop and
> > the system can't suspend.
> >
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> -stable too, yeah?
Its not a critical bugfix, at least for me.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-19 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-17 0:14 virtio-balloon: check for freezer in kthread loop Marcelo Tosatti
2009-04-19 13:44 ` Rusty Russell
2009-04-19 14:00 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).