Re: [PATCH] xen block: remove driver_data direct access of struct device

[Greg KH <greg@kroah.com>]

On Thu, Apr 30, 2009 at 03:35:35PM -0700, Chris Wright wrote:
> * Greg Kroah-Hartman (gregkh@suse.de) wrote:
> > In the near future, the driver core is going to not allow direct access
> > to the driver_data pointer in struct device.  Instead, the functions
> > dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
> > have been around since the beginning, so are backwards compatible with
> > all older kernel versions.
> > 
> > Cc: xen-devel@lists.xensource.com
> > Cc: virtualization@lists.osdl.org
> > Cc: Chris Wright <chrisw@sous-sol.org>
> > Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> Acked-by: Chris Wright <chrisw@sous-sol.org>

Thanks, will add it.  Any objections for this to go through my
driver-core tree to Linus for 2.6.31?

> after...
> 
> > -		dev->dev.driver_data = NULL;
> > +		dev_det_drvdata(&dev->dev, NULL);
> 
> ...fixing your fingers/script so it compiles ;-)

Doh!

And here I thought I had built that one, I guess I hadn't, my mistake.
Thanks for catching that, I've now fixed it.

greg k-h