From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
virtualization@lists.linux-foundation.org,
Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] msi-x: let drivers retry when not enough vectors
Date: Thu, 7 May 2009 12:31:37 +0300 [thread overview]
Message-ID: <20090507093137.GD32039@redhat.com> (raw)
In-Reply-To: <200905071710.47204.sheng@linux.intel.com>
On Thu, May 07, 2009 at 05:10:46PM +0800, Sheng Yang wrote:
> > > I think driver should read from capability list to know how many vector
> > > supported by this device before enable MSI-X for device, as
> > > pci_msix_table_size() did...
> >
> > Drivers can do this, but it's more code. Since pci_enable_msix
> > calls pci_msix_table_size already, let it do the work. Right?
>
> If you don't know the vectors number before you enable MSI-X, how can you
> setup vectors?
I don't know how many irqs I will be able to get anyway.
vectors that can't be assigned are useless ...
--
MST
next prev parent reply other threads:[~2009-05-07 9:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090507082841.GA31751@redhat.com>
2009-05-07 8:51 ` [PATCH] msi-x: let drivers retry when not enough vectors Sheng Yang
[not found] ` <200905071651.24970.sheng@linux.intel.com>
2009-05-07 9:05 ` Michael S. Tsirkin
[not found] ` <20090507090506.GB32039@redhat.com>
2009-05-07 9:10 ` Sheng Yang
[not found] ` <200905071710.47204.sheng@linux.intel.com>
2009-05-07 9:31 ` Michael S. Tsirkin [this message]
2009-05-07 9:27 ` Matthew Wilcox
[not found] ` <20090507092731.GH8112@parisc-linux.org>
2009-05-07 9:40 ` Sheng Yang
[not found] ` <200905071740.16190.sheng@linux.intel.com>
2009-05-07 9:53 ` Matthew Wilcox
[not found] ` <20090507095302.GI8112@parisc-linux.org>
2009-05-07 10:19 ` Sheng Yang
2009-05-07 10:23 ` Michael Ellerman
[not found] ` <1241691830.24385.6.camel@concordia>
2009-05-07 10:28 ` Sheng Yang
2009-05-07 10:44 ` Avi Kivity
[not found] ` <4A02BB96.8070103@redhat.com>
2009-05-07 11:57 ` Matthew Wilcox
[not found] ` <200905071819.54426.sheng@linux.intel.com>
2009-05-07 10:32 ` Michael S. Tsirkin
2009-05-07 23:55 ` Rusty Russell
[not found] ` <200905080925.01398.rusty@rustcorp.com.au>
2009-05-08 0:22 ` Matthew Wilcox
2009-05-08 0:28 ` Michael Ellerman
2009-05-12 21:28 ` Michael S. Tsirkin
2009-06-11 18:28 ` Jesse Barnes
2009-05-07 8:28 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507093137.GD32039@redhat.com \
--to=mst@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).