virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: dlaor@redhat.com
Cc: Chris Wright <chrisw@redhat.com>,
	Mark McLoughlin <markmc@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	kvm@vger.kernel.org, Brian Stein <bstein@redhat.com>,
	Herbert Xu <herbert.xu@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	virtualization@lists.linux-foundation.org,
	Dor Laor <dor@redhat.com>, Avi Kivity <avi@redhat.com>,
	Yaron Haviv <yaronh@voltaire.com>
Subject: Re: TODO list for qemu+KVM networking performance v2
Date: Thu, 11 Jun 2009 00:09:33 +0930	[thread overview]
Message-ID: <200906110009.34671.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A2F5217.9090401@redhat.com>

On Wed, 10 Jun 2009 03:56:31 pm Dor Laor wrote:
> Rusty Russell wrote:
> > The current theoretical hole is that the host suppresses notifications
> > using the VIRTIO_AVAIL_F_NO_NOTIFY flag, but we can get a number of
> > notifications in before it gets to that suppression.  You can use a
> > counter to improve this: you only notify when they're equal, and inc when
> > you notify.  That way you suppress further notifications even if the
> > other side takes ages to wake up. In practice, this shouldn't be played
> > with until we have full aio (or equiv in kernel) for other side: host
> > xmit tends to be too fast at the moment and we get a notification per
> > packet anyway.
>
> Xen ring has the exact optimization for ages. imho we should have it
> too, regardless of aio.
> It reduces #vmexits/spurious wakeups and it is very simple to implement.

But look at number of wakeups received vs notifications sent: I just don't see 
any benefit there at the moment.  As I said, improving the host code might 
change that significantly.

And implementing it the other way is v. v. hard given the nature of interrupts 
(shared and coalesced).

Thanks,
Rusty.

  parent reply	other threads:[~2009-06-10 14:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090604164320.GB14592@redhat.com>
2009-06-04 17:16 ` TODO list for qemu+KVM networking performance v2 Gregory Haskins
     [not found] ` <4A280155.2060100@gmail.com>
2009-06-04 17:29   ` Michael S. Tsirkin
     [not found]   ` <20090604172934.GA16012@redhat.com>
2009-06-04 17:50     ` Gregory Haskins
     [not found]     ` <4A28095C.2090002@gmail.com>
2009-06-04 18:10       ` Michael S. Tsirkin
2009-06-10  3:39 ` Rusty Russell
     [not found] ` <200906101309.14532.rusty@rustcorp.com.au>
2009-06-10  6:26   ` Dor Laor
     [not found]   ` <4A2F5217.9090401@redhat.com>
2009-06-10 14:39     ` Rusty Russell [this message]
2009-06-10 14:53       ` Michael S. Tsirkin
     [not found]       ` <20090610145358.GB28601@redhat.com>
2009-06-10 15:18         ` Avi Kivity
     [not found]         ` <4A2FCEA9.8010604@redhat.com>
2009-06-10 15:54           ` Michael S. Tsirkin
     [not found]           ` <20090610155428.GI28601@redhat.com>
2009-06-10 16:08             ` Avi Kivity
     [not found]             ` <4A2FDA91.4070903@redhat.com>
2009-06-10 16:28               ` Michael S. Tsirkin
2009-06-04 16:43 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906110009.34671.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=bstein@redhat.com \
    --cc=chrisw@redhat.com \
    --cc=dlaor@redhat.com \
    --cc=dor@redhat.com \
    --cc=herbert.xu@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yaronh@voltaire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).