From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] virtio: Add a can_add_buf helper
Date: Tue, 25 Aug 2009 20:05:17 +0530 [thread overview]
Message-ID: <20090825143517.GA27028@amit-x200.redhat.com> (raw)
In-Reply-To: <200908252357.54455.rusty@rustcorp.com.au>
On (Tue) Aug 25 2009 [23:57:54], Rusty Russell wrote:
> On Mon, 24 Aug 2009 05:09:44 pm Amit Shah wrote:
> > sg_init_table(sg, 2+MAX_SKB_FRAGS);
> > - for (;;) {
> > + ret = 1;
> > + while(ret > 0) { /* Is there space to add another buffer to the vq */
>
> This is called a "do" loop :)
>
> Please test, and I'll apply.
:-) drat! shouldn't have done that on a Sunday anyway
I'll test it soon.
Amit
prev parent reply other threads:[~2009-08-25 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 16:01 [PATCH 1/2] virtio: Add a can_add_buf helper Amit Shah
2009-08-18 16:01 ` [PATCH 2/2] virtio_net: Use can_add_buf to test for enough room to add Amit Shah
2009-08-22 8:01 ` [PATCH 1/2] virtio: Add a can_add_buf helper Rusty Russell
[not found] ` <20090824073944.GA7653@amit-x200.redhat.com>
2009-08-25 14:27 ` Rusty Russell
2009-08-25 14:35 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090825143517.GA27028@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).