From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: john cooper <john.cooper@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.
Date: Wed, 30 Sep 2009 09:41:24 +0200 [thread overview]
Message-ID: <200909300941.24736.borntraeger@de.ibm.com> (raw)
In-Reply-To: <200909300248.09630.rusty@rustcorp.com.au>
Am Dienstag 29 September 2009 19:18:09 schrieb Rusty Russell:
> PCI, lguest and s390 can all only support 256-byte configuration
> space. So, this giant field broke just about everyone.
> Unfortunately, removing it is not so simple: we don't want to break
> old userspace, but we're going to want to re-use that part of the
> struct.
>
> So, modern users can #define VIRTIO_BLK_IDENTIFY_DEPRECATED to indicate
> that they know it's no longer in the config struct, and can use any
> new features (all new features which add a configuration field will
> conflict with this deprecated one).
Since s390 never used the giant id field, it would be ok for us just delete it
(without the #define). IIRC kvm-userspace also never used that. Since qemu
upstream seems to use that field your way seems to be the only compatible...
O dear, virtio used to look pretty ;-).
I think somewhen in the future we have to create a virtio2 that gets rid of all
the stuff that accumulated in the early phase of Linux virtualization.
Anyway, your patch was tested successfully on s390 to survive the current
userspace.
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
next parent reply other threads:[~2009-09-30 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200909300248.09630.rusty@rustcorp.com.au>
2009-09-30 7:41 ` Christian Borntraeger [this message]
2009-10-05 16:20 ` [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field john cooper
[not found] ` <4ACA1CBC.8020402@redhat.com>
2009-10-06 9:21 ` Rusty Russell
2009-10-07 5:48 ` john cooper
2009-09-29 17:18 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909300941.24736.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=john.cooper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).