Re: [PATCH 07/28] virtio: console: don't assume a single console port.

[Amit Shah <amit.shah@redhat.com>]

On (Mon) Nov 30 2009 [12:20:02], Rusty Russell wrote:
> On Sat, 28 Nov 2009 05:20:30 pm Amit Shah wrote:
> > Keep a list of all ports being used as a console, and provide a lock
> > and a lookup function.  The hvc callbacks only give us a vterm number,
> > so we need to map this.
> 
> OK, I think we can do better than this.
> 
> How about we introduce a 'struct console_port', like so:
> 
> 	/* A port which is used as a console. */
> 	struct console_port {
> 		struct port port;
> 
> 		u32 vtermno;
> 		struct list_head list;
> 	};
> 
> 	static DEFINE_SPINLOCK(console_lock);
> 	static LIST_HEAD(consoles);

I tried to keep your patches close to the ones you sent -- I make a
change similar to this in patch 14. I can fold the two into one,
obviously.

(I'll wait for comments to the other patches in the series before
sending out a new respin.)

Thanks!
		Amit