From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: virtio: console: Return -EFAULT on copy_xx_user errors, allow larger writes
Date: Sat, 30 Jan 2010 15:25:08 +1030 [thread overview]
Message-ID: <201001301525.08208.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1264772563-25517-1-git-send-email-amit.shah@redhat.com>
On Sat, 30 Jan 2010 12:12:37 am Amit Shah wrote:
> These updated patches in the series return -EFAULT on copy_xx_user
> errors and also move the copy_from_user into fops_write() instead of it
> being in send_buf. This enables send_buf to just read from kernel
> buffers, making it simpler.
>
> This also allows write()s to write more to the host in one go,
> removingthe 4k limitation. I do limit the writes to 32k at once to not
> put too much pressure on the GFP_KERNEL area.
>
> Both of these were pointed out by Marcelo.
Applied.
Thanks,
Rusty.
prev parent reply other threads:[~2010-01-30 4:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 13:42 virtio: console: Return -EFAULT on copy_xx_user errors, allow larger writes Amit Shah
2010-01-29 13:42 ` [PATCH 19/31] virtio: console: Introduce a send_buf function for a common path for sending data to host Amit Shah
2010-01-29 13:42 ` [PATCH 20/31] virtio: console: Add a new MULTIPORT feature, support for generic ports Amit Shah
2010-01-29 13:42 ` [PATCH 21/31] virtio: console: Prepare for writing to userspace buffers Amit Shah
2010-01-29 13:42 ` [PATCH 22/31] virtio: console: Associate each port with a char device Amit Shah
2010-01-29 13:42 ` [PATCH 23/31] virtio: console: Add file operations to ports for open/read/write/poll Amit Shah
2010-01-29 13:42 ` [PATCH 29/31] virtio: console: Add ability to hot-unplug ports Amit Shah
2010-02-01 0:19 ` [PATCH 21/31] virtio: console: Prepare for writing to userspace buffers Rusty Russell
2010-02-01 5:08 ` Amit Shah
2010-01-30 4:55 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001301525.08208.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).