Re: [PATCH 21/31] virtio: console: Prepare for writing to userspace buffers

[Rusty Russell <rusty@rustcorp.com.au>]

On Sat, 30 Jan 2010 12:12:40 am Amit Shah wrote:
> When ports get advertised as char devices, the buffers will come from
> userspace. Equip the fill_readbuf function with the ability to write
> to userspace buffers.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  drivers/char/virtio_console.c |   20 ++++++++++++++------
>  1 files changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 9d33239..5f61021 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -365,7 +365,8 @@ fail:
>   * Give out the data that's requested from the buffer that we have
>   * queued up.
>   */
> -static ssize_t fill_readbuf(struct port *port, char *out_buf, size_t out_count)
> +static ssize_t fill_readbuf(struct port *port, char *out_buf, size_t out_count,
> +			    bool to_user)

This patch does not apply: your previous 19/31 "Introduce a send_buf function
for a common path for sending data to host" made this "void *out_buf".  The
rest I can't even sort out.

I have dropped 19/31 onwards, as listed below.  Please re-xmit privately,
tarball is fine.

Thanks,
Rusty.

Subject: virtio: console: Introduce a send_buf function for a common path for sending data to host
Subject: virtio: console: Add a new MULTIPORT feature, support for generic ports
Subject: virtio: console: Prepare for writing to / reading from userspace buffers
Subject: virtio: console: Associate each port with a char device
Subject: virtio: console: Add file operations to ports for open/read/write/poll
Subject: virtio: console: Ensure only one process can have a port open at a time
Subject: virtio: console: Register with sysfs and create a 'name' attribute for ports
Subject: virtio: console: Remove cached data on port close
Subject: virtio: console: Handle port hot-plug
Subject: virtio: console: Add ability to hot-unplug ports
Subject: virtio: console: Add debugfs files for each port to expose debug info
Subject: virtio: console: show error message if hvc_alloc fails for console ports