From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 0/6] virtio: console: Fixes
Date: Fri, 12 Feb 2010 14:37:56 +0530 [thread overview]
Message-ID: <20100212090756.GG12497@amit-x200.redhat.com> (raw)
In-Reply-To: <201002121934.58477.rusty@rustcorp.com.au>
On (Fri) Feb 12 2010 [19:34:58], Rusty Russell wrote:
> On Fri, 12 Feb 2010 03:32:13 pm Amit Shah wrote:
> > Hey Rusty,
> >
> > Here are a few fixes for virtio and virtio_console.
> >
> > The first patch ensures the data elements of vqs are properly
> > initialised at allocation-time so that we don't trigger BUG_ONs. I found
> > this when hot-unplugging ports and there was just one unused buffer.
> > detach_unused_buffers() kept returning pointers that were invalid. I
> > didn't catch this earlier as I had the in_vq filled completely.
> >
> > Patches 2, 4 and 5 can be folded into the series as they are bugfixes
> > for the functionality present there.
> >
> > About patch 5: When running a test that transfers a 260M file from the
> > host to the guest, qemu-kvm.git takes 17m with a single outstanding
> > buffer in the in_vq vs. 1m when the entire in_vq is filled. This is a
> > bug in qemu-kvm.git's scheduling, but since it's a big difference and
> > not much change involved, we could merge this now.
> >
> > Comments?
> >
> > If these patches are favourable, I could send you a tarball in private
> > so that the bugfixes are folded in the series and just patches 1, 3 and
> > 6 are added.
>
> I prefer to fold them myself, after they've spent some time in linux-next.
Fine by me.
BTW should patch 1 be considered for stable?
Thanks!
Amit
prev parent reply other threads:[~2010-02-12 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 5:02 [PATCH 0/6] virtio: console: Fixes Amit Shah
2010-02-12 5:02 ` [PATCH 1/6] virtio: Initialize vq->data entries to NULL Amit Shah
2010-02-12 5:02 ` [PATCH 2/6] virtio: console: Ensure no memleaks in case of unused buffers Amit Shah
2010-02-12 5:02 ` [PATCH 3/6] virtio: console: Add ability to remove module Amit Shah
2010-02-12 5:02 ` [PATCH 4/6] virtio: console: Error out if we can't allocate buffers for control queue Amit Shah
2010-02-12 5:02 ` [PATCH 5/6] virtio: console: Fill ports' entire in_vq with buffers Amit Shah
2010-02-12 5:02 ` [PATCH 6/6] Add MAINTAINERS entry for virtio_console Amit Shah
2010-02-12 9:58 ` [PATCH 1/6] virtio: Initialize vq->data entries to NULL Rusty Russell
2010-02-12 9:04 ` [PATCH 0/6] virtio: console: Fixes Rusty Russell
2010-02-12 9:07 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212090756.GG12497@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).