From: Amit Shah <amit.shah@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@linux-foundation.org, quintela@redhat.com
Subject: Re: [PATCH 0/2] virtio: console: Trivial fixes based on review comments
Date: Tue, 9 Mar 2010 09:25:56 +0530 [thread overview]
Message-ID: <20100309035556.GA18898@amit-x200.redhat.com> (raw)
In-Reply-To: <20100308212319.GA13886@redhat.com>
On (Mon) Mar 08 2010 [23:23:20], Michael S. Tsirkin wrote:
> On Mon, Mar 08, 2010 at 02:16:58PM +0530, Amit Shah wrote:
> > Hello,
> >
> > Here are a couple of small fixes for the virtio_console code, it's mostly
> > stylistic fixes.
> >
> > Michael, can you push these to Linus? Thanks.
>
> We are in fixes only mode now. Does the first patch fix a bug,
> or is it cosmetic only?
No, it's not a bug fix. The value written to 'len' is write-only, we
never read from it.
Amit
next prev parent reply other threads:[~2010-03-09 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 8:46 [PATCH 0/2] virtio: console: Trivial fixes based on review comments Amit Shah
2010-03-08 8:46 ` [PATCH 1/2] virtio: console: Fix type of 'len' as unsigned int Amit Shah
2010-03-08 8:47 ` [PATCH 2/2] virtio: console: Use better variable names for fill_queue operation Amit Shah
2010-03-08 10:34 ` [PATCH 0/2] virtio: console: Trivial fixes based on review comments Juan Quintela
2010-03-08 21:23 ` Michael S. Tsirkin
2010-03-09 3:55 ` Amit Shah [this message]
2010-03-09 6:28 ` Michael S. Tsirkin
2010-03-09 6:36 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309035556.GA18898@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=quintela@redhat.com \
--cc=virtualization@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).