From: Amit Shah <amit.shah@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com,
virtualization@lists.linux-foundation.org, mst@redhat.com
Subject: Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages
Date: Mon, 22 Mar 2010 10:48:02 +0530 [thread overview]
Message-ID: <20100322051802.GE24577@amit-x200.redhat.com> (raw)
In-Reply-To: <4BA47C02.3000105@redhat.com>
On (Sat) Mar 20 2010 [09:40:50], Avi Kivity wrote:
> On 03/19/2010 01:58 PM, Amit Shah wrote:
>> +
>> + offset = 0;
>> + for (i = 0; i< elem.out_num; i++) {
>> + memcpy(buf + offset, elem.out_sg[i].iov_base,
>> + elem.out_sg[i].iov_len);
>> + offset += elem.out_sg[i].iov_len;
>> + }
>> + len = cur_len;
>> +
>> + handle_control_message(vser, buf, len);
>> + virtqueue_push(vq,&elem, len);
>> + }
>> + if (len) {
>> + qemu_free(buf);
>> }
>> virtio_notify(vdev, vq);
>> }
>
> Isn't there some virtio function to linearize requests?
I don't see one.
Amit
next prev parent reply other threads:[~2010-03-22 5:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 11:58 [PATCH 0/9] virtio-serial fixes, ABI updates Amit Shah
2010-03-19 11:58 ` [PATCH 1/9] virtio-serial-bus: save/load: Ensure target has enough ports Amit Shah
2010-03-19 11:58 ` [PATCH 2/9] virtio-serial-bus: save/load: Ensure nr_ports on src and dest are same Amit Shah
2010-03-19 11:58 ` [PATCH 3/9] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated Amit Shah
2010-03-19 11:58 ` [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages Amit Shah
2010-03-19 11:58 ` [PATCH 5/9] virtio-serial: Handle scatter/gather input from the guest Amit Shah
2010-03-19 11:58 ` [PATCH 6/9] virtio-serial: Remove redundant check for 0-sized write request Amit Shah
2010-03-19 11:58 ` [PATCH 7/9] virtio-serial: Update copyright year to 2010 Amit Shah
2010-03-19 11:58 ` [PATCH 8/9] virtio-serial-bus: Use a bitmap in virtio config space for active ports Amit Shah
2010-03-19 11:58 ` [PATCH 9/9] virtio-serial-bus: Let the guest know of host connection changes after migration Amit Shah
2010-03-20 7:40 ` [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages Avi Kivity
2010-03-22 5:18 ` Amit Shah [this message]
2010-03-23 15:51 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-23 16:15 ` Amit Shah
2010-03-23 16:23 ` Michael S. Tsirkin
2010-03-21 13:47 ` [PATCH 0/9] virtio-serial fixes, ABI updates Michael S. Tsirkin
2010-03-22 4:55 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322051802.GE24577@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).