From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Amit Shah <amit.shah@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 4/4] virtio: disable multiport console support.
Date: Wed, 31 Mar 2010 21:35:39 +0300 [thread overview]
Message-ID: <20100331183539.GA5241@redhat.com> (raw)
In-Reply-To: <201003301549.43186.rusty@rustcorp.com.au>
On Tue, Mar 30, 2010 at 03:49:43PM +1030, Rusty Russell wrote:
> Unfortunately there proved to be at least one bug which requires an
> ABI change, so we're best off not introducing multiport support until
> 2.6.35.
>
> While I generally left the multiport code paths intact, I really wanted
> to remove the ABI defines from the header, which meant some quite deep cuts.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> To: Amit Shah <amit.shah@redhat.com>
> ---
> diff --git a/include/linux/virtio_console.h b/include/linux/virtio_console.h
> --- a/include/linux/virtio_console.h
> +++ b/include/linux/virtio_console.h
> @@ -12,7 +12,6 @@
>
> /* Feature bits */
> #define VIRTIO_CONSOLE_F_SIZE 0 /* Does host provide console size? */
> -#define VIRTIO_CONSOLE_F_MULTIPORT 1 /* Does host provide multiple ports? */
>
> struct virtio_console_config {
> /* colums of the screens */
> @@ -25,24 +24,6 @@ struct virtio_console_config {
> __u32 nr_ports;
> } __attribute__((packed));
We also want to remove nr_ports, correct?
next prev parent reply other threads:[~2010-03-31 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 5:19 [PATCH 4/4] virtio: disable multiport console support Rusty Russell
2010-03-30 6:29 ` Amit Shah
2010-03-31 18:35 ` Michael S. Tsirkin [this message]
2010-03-31 18:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331183539.GA5241@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).