Linux virtualization list
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Juan Quintela <quintela@redhat.com>,
	Virtualization List <virtualization@lists.linux-foundation.org>
Subject: [PULL] virtio console fixes, abi change
Date: Wed, 14 Apr 2010 11:05:57 +0530	[thread overview]
Message-ID: <20100414053557.GA4442@amit-x200.redhat.com> (raw)

Hello Rusty,

To avoid sending the same patches again, this time I'm trying a git pull
request.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/amit/vs-kernel.git for-rusty

to get the patches that I've sent to the list previously, with a couple
of fixes:

- Create a console port when not using multiport (fix was sent as a
  reply to prev. series)

- Add hunk that got inadvertently reverted during git rebase operations
  (thanks Juan).

The diff to the v6 version is attached below:

diff --git a/drivers/char/virtio_console.c
b/drivers/char/virtio_console.c
index b06a0e5..a64558f 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1083,6 +1083,8 @@ free_cdev:
 free_port:
        kfree(port);
 fail:
+       /* The host might want to notify management sw about port add
failure */
+       send_control_msg(port, VIRTIO_CONSOLE_PORT_READY, 0);
        return err;
 }
@@ -1407,17 +1513,14 @@ static int __devinit virtcons_probe(struct
virtio_device *vdev)
                        err = -ENOMEM;
                        goto free_vqs;
                }
+       } else {
+               /*
+                * For backward compatibility: Create a console port
+                * if we're running on older host.
+                */
+               add_port(portdev, 0);
        }

Thanks,
		Amit

             reply	other threads:[~2010-04-14  5:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14  5:35 Amit Shah [this message]
2010-04-14  7:25 ` [PULL] virtio console fixes, abi change Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100414053557.GA4442@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=quintela@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox