* [PULL] virtio fixes
@ 2009-10-19 2:31 Rusty Russell
0 siblings, 0 replies; 7+ messages in thread
From: Rusty Russell @ 2009-10-19 2:31 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, virtualization
(Sorry for delay, recent absences, but all been in linux-next a week now)
The following changes since commit 2fdc246aaf9a7fa088451ad2a72e9119b5f7f029:
Linus Torvalds (1):
Merge branch 'for-linus' of git://git.kernel.org/.../bp/bp
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master
Christian Borntraeger (1):
virtio: let header files include virtio_ids.h
Christoph Hellwig (1):
virtio_blk: revert QUEUE_FLAG_VIRT addition
Rusty Russell (1):
virtio_blk: Revert serial number support
Uwe Kleine-König (2):
move virtballoon_remove to .devexit.text
move virtrng_remove to .devexit.text
Documentation/lguest/lguest.c | 1 -
drivers/block/virtio_blk.c | 39 ++--------------------------------
drivers/char/hw_random/virtio-rng.c | 3 +-
drivers/char/virtio_console.c | 1 -
drivers/net/virtio_net.c | 1 -
drivers/virtio/virtio_balloon.c | 3 +-
include/linux/Kbuild | 1 +
include/linux/virtio_9p.h | 1 +
include/linux/virtio_balloon.h | 1 +
include/linux/virtio_blk.h | 5 +---
include/linux/virtio_console.h | 1 +
include/linux/virtio_net.h | 1 +
include/linux/virtio_rng.h | 1 +
net/9p/trans_virtio.c | 1 -
14 files changed, 12 insertions(+), 48 deletions(-)
commit d5a01175aa25ef30a99545f09e0a2828a226d3cd
Author: Christoph Hellwig <hch@lst.de>
Date: Fri Sep 4 22:44:42 2009 +0200
virtio_blk: revert QUEUE_FLAG_VIRT addition
It seems like the addition of QUEUE_FLAG_VIRT caueses major performance
regressions for Fedora users:
https://bugzilla.redhat.com/show_bug.cgi?id=509383
https://bugzilla.redhat.com/show_bug.cgi?id=505695
while I can't reproduce those extreme regressions myself I think the flag
is wrong.
Rationale:
QUEUE_FLAG_VIRT expands to QUEUE_FLAG_NONROT which casus the queue
unplugged immediately. This is not a good behaviour for at least
qemu and kvm where we do have significant overhead for every
I/O operations. Even with all the latested speeups (native AIO,
MSI support, zero copy) we can only get native speed for up to 128kb
I/O requests we already are down to 66% of native performance for 4kb
requests even on my laptop running the Intel X25-M SSD for which the
QUEUE_FLAG_NONROT was designed.
If we ever get virtio-blk overhead low enough that this flag makes
sense it should only be set based on a feature flag set by the host.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/block/virtio_blk.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
commit 6ff87d1f188f65a51c28595e9ad16183cbd58d94
Author: Christian Borntraeger <borntraeger@de.ibm.com>
Date: Wed Sep 30 11:17:21 2009 +0200
virtio: let header files include virtio_ids.h
Rusty,
commit 3ca4f5ca73057a617f9444a91022d7127041970a
virtio: add virtio IDs file
moved all device IDs into a single file. While the change itself is
a very good one, it can break userspace applications. For example
if a userspace tool wanted to get the ID of virtio_net it used to
include virtio_net.h. This does no longer work, since virtio_net.h
does not include virtio_ids.h.
This patch moves all "#include <linux/virtio_ids.h>" from the C
files into the header files, making the header files compatible with
the old ones.
In addition, this patch exports virtio_ids.h to userspace.
CC: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Documentation/lguest/lguest.c | 1 -
drivers/block/virtio_blk.c | 1 -
drivers/char/hw_random/virtio-rng.c | 1 -
drivers/char/virtio_console.c | 1 -
drivers/net/virtio_net.c | 1 -
drivers/virtio/virtio_balloon.c | 1 -
include/linux/Kbuild | 1 +
include/linux/virtio_9p.h | 1 +
include/linux/virtio_balloon.h | 1 +
include/linux/virtio_blk.h | 1 +
include/linux/virtio_console.h | 1 +
include/linux/virtio_net.h | 1 +
include/linux/virtio_rng.h | 1 +
net/9p/trans_virtio.c | 1 -
14 files changed, 7 insertions(+), 7 deletions(-)
commit ef728ac6296b8ae36791c7644e92b7bc75c0fd88
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Oct 19 12:58:28 2009 -0600
virtio_blk: Revert serial number support
This reverts "Add serial number support for virtio_blk, V4a".
Turns out that virtio_pci, lguest and s/390 all have an 8 bit limit
on virtio config space, so noone could ever use this.
This is coming back later in a cleaner form.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: john cooper <john.cooper@redhat.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
drivers/block/virtio_blk.c | 37 +++----------------------------------
include/linux/virtio_blk.h | 4 ----
2 files changed, 3 insertions(+), 38 deletions(-)
commit 22b4b8fe00398cb66cb9a95d3f0c21b0155e5421
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu Oct 1 10:28:33 2009 +0200
move virtballoon_remove to .devexit.text
The function virtballoon_remove is used only wrapped by __devexit_p so
define it using __devexit.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/virtio/virtio_balloon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit 360390725dce2961ac35be5f59640f9d44f03d25
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu Oct 1 10:28:35 2009 +0200
move virtrng_remove to .devexit.text
The function virtrng_remove is used only wrapped by __devexit_p so define
it using __devexit.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/hw_random/virtio-rng.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL] virtio fixes
[not found] <200910191301.24726.rusty@rustcorp.com.au>
@ 2009-10-21 23:31 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0910220831090.9771@eeepc.linux-foundation.org>
1 sibling, 0 replies; 7+ messages in thread
From: Linus Torvalds @ 2009-10-21 23:31 UTC (permalink / raw)
To: Rusty Russell; +Cc: linux-kernel, virtualization
On Mon, 19 Oct 2009, Rusty Russell wrote:
>
> ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master
"Already up-to-date.".
Forgot to push?
Linus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL] virtio fixes
[not found] ` <alpine.LFD.2.00.0910220831090.9771@eeepc.linux-foundation.org>
@ 2009-10-22 6:13 ` Rusty Russell
0 siblings, 0 replies; 7+ messages in thread
From: Rusty Russell @ 2009-10-22 6:13 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, virtualization
On Thu, 22 Oct 2009 10:01:43 am Linus Torvalds wrote:
>
> On Mon, 19 Oct 2009, Rusty Russell wrote:
> >
> > ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master
>
> "Already up-to-date.".
>
> Forgot to push?
Oops, overzealous master.kernel.org space reclamation from me :
This time for sure!
Rusty/
The following changes since commit 2fdc246aaf9a7fa088451ad2a72e9119b5f7f029:
Linus Torvalds (1):
Merge branch 'for-linus' of git://git.kernel.org/.../bp/bp
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master
Christian Borntraeger (1):
virtio: let header files include virtio_ids.h
Christoph Hellwig (1):
virtio_blk: revert QUEUE_FLAG_VIRT addition
Rusty Russell (1):
virtio_blk: Revert serial number support
Uwe Kleine-König (2):
move virtballoon_remove to .devexit.text
move virtrng_remove to .devexit.text
Documentation/lguest/lguest.c | 1 -
drivers/block/virtio_blk.c | 39 ++--------------------------------
drivers/char/hw_random/virtio-rng.c | 3 +-
drivers/char/virtio_console.c | 1 -
drivers/net/virtio_net.c | 1 -
drivers/virtio/virtio_balloon.c | 3 +-
include/linux/Kbuild | 1 +
include/linux/virtio_9p.h | 1 +
include/linux/virtio_balloon.h | 1 +
include/linux/virtio_blk.h | 5 +---
include/linux/virtio_console.h | 1 +
include/linux/virtio_net.h | 1 +
include/linux/virtio_rng.h | 1 +
net/9p/trans_virtio.c | 1 -
14 files changed, 12 insertions(+), 48 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL] virtio fixes
@ 2010-06-03 13:13 Rusty Russell
0 siblings, 0 replies; 7+ messages in thread
From: Rusty Russell @ 2010-06-03 13:13 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Amit Shah, Christoph Hellwig, virtualization
The following changes since commit aef4b9aaae1decc775778903922bd0075cce7a88:
Linus Torvalds (1):
Merge branch 'next' of git://git.kernel.org/.../benh/powerpc
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git virtio
Amit Shah (2):
virtio: console: Fix crash when hot-unplugging a port and read is blocked
virtio: console: Fix crash when port is unplugged and blocked for write
Christoph Hellwig (1):
virtio-blk: fix minimum number of S/G elements
drivers/block/virtio_blk.c | 4 +++-
drivers/char/virtio_console.c | 14 +++++++++++---
2 files changed, 14 insertions(+), 4 deletions(-)
commit a5b365a652206ca300256974ed9301a7d241a6ed
Author: Christoph Hellwig <hch@lst.de>
Date: Tue May 25 14:17:54 2010 +0200
virtio-blk: fix minimum number of S/G elements
We need at least one S/G element to operate properly, as does the block
layer which increments it to one anyway. We hit this due to a qemu
bug which advertises a sg_elements of 0 under some circumstances.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (tweaked logic)
drivers/block/virtio_blk.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
commit 0047634d3daebca9e99a22eb89167bf77f35cdfa
Author: Amit Shah <amit.shah@redhat.com>
Date: Thu May 27 13:24:39 2010 +0530
virtio: console: Fix crash when hot-unplugging a port and read is blocked
When removing a port we don't check if a program was blocked for read.
This leads to a crash when SIGTERM is sent to the program after
hot-unplugging the port.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/virtio_console.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
commit 60e5e0b84045ce0f6ab07a02c7fcd6627b53d2d3
Author: Amit Shah <amit.shah@redhat.com>
Date: Thu May 27 13:24:40 2010 +0530
virtio: console: Fix crash when port is unplugged and blocked for write
When a program that has a virtio port opened and blocked for a write
operation, a port hot-unplug event will later led to a crash when
SIGTERM was sent to the program. Fix that.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/virtio_console.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL] virtio fixes
@ 2010-06-23 13:20 Rusty Russell
0 siblings, 0 replies; 7+ messages in thread
From: Rusty Russell @ 2010-06-23 13:20 UTC (permalink / raw)
To: Linus Torvalds
Cc: David Miller, virtualization, linux-kernel, Michael S. Tsirkin
(There are two net fixes which depend on this which will go via DaveM, so
please pull soon).
The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
Linus Torvalds (1):
Linux 2.6.35-rc3
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6.git virtio
Michael S. Tsirkin (2):
virtio: return ENOMEM on out of memory
virtio-pci: disable msi at startup
drivers/pci/pci.c | 1 +
drivers/virtio/virtio_pci.c | 3 +++
drivers/virtio/virtio_ring.c | 2 +-
3 files changed, 5 insertions(+), 1 deletions(-)
commit 686d363786a53ed28ee875b84ef24e6d5126ef6f
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Thu Jun 10 18:16:11 2010 +0300
virtio: return ENOMEM on out of memory
add_buf returns ring size on out of memory,
this is not what devices expect.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org # .34.x
drivers/virtio/virtio_ring.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit b03214d559471359e2a85ae256686381d0672f29
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Wed Jun 23 22:49:06 2010 -0600
virtio-pci: disable msi at startup
virtio-pci resets the device at startup by writing to the status
register, but this does not clear the pci config space,
specifically msi enable status which affects register
layout.
This breaks things like kdump when they try to use e.g. virtio-blk.
Fix by forcing msi off at startup. Since pci.c already has
a routine to do this, we export and use it instead of duplicating code.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
drivers/pci/pci.c | 1 +
drivers/virtio/virtio_pci.c | 3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL] virtio: fixes
@ 2019-02-06 19:32 Michael S. Tsirkin
0 siblings, 0 replies; 7+ messages in thread
From: Michael S. Tsirkin @ 2019-02-06 19:32 UTC (permalink / raw)
To: Linus Torvalds; +Cc: kvm, mst, netdev, linux-kernel, virtualization
The following changes since commit 49a57857aeea06ca831043acbb0fa5e0f50602fd:
Linux 5.0-rc3 (2019-01-21 13:14:44 +1300)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to 9c0644ee4aa8792f1e60a2b014b4710faaddafeb:
virtio: drop internal struct from UAPI (2019-02-05 15:29:48 -0500)
----------------------------------------------------------------
virtio: fixes
A small fix for a uapi header, and a fix for VDPA for non-x86 guests.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Michael S. Tsirkin (1):
virtio: drop internal struct from UAPI
Tiwei Bie (1):
virtio: support VIRTIO_F_ORDER_PLATFORM
drivers/virtio/virtio_ring.c | 15 ++++++++++++++-
include/uapi/linux/virtio_config.h | 6 ++++++
include/uapi/linux/virtio_ring.h | 10 ----------
3 files changed, 20 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL] virtio: fixes
@ 2019-04-10 13:18 Michael S. Tsirkin
0 siblings, 0 replies; 7+ messages in thread
From: Michael S. Tsirkin @ 2019-04-10 13:18 UTC (permalink / raw)
To: Linus Torvalds
Cc: kvm, mst, netdev, cohuck, linux-kernel, virtualization, longpeng2
The following changes since commit 15ade5d2e7775667cf191cf2f94327a4889f8b9d:
Linux 5.1-rc4 (2019-04-07 14:09:59 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to cf94db21905333e610e479688add629397a4b384:
virtio: Honour 'may_reduce_num' in vring_create_virtqueue (2019-04-08 17:05:52 -0400)
----------------------------------------------------------------
virtio: fixes, reviewers
Several fixes, add more reviewers to the list
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Cornelia Huck (1):
virtio: Honour 'may_reduce_num' in vring_create_virtqueue
Longpeng (1):
virtio_pci: fix a NULL pointer reference in vp_del_vqs
Michael S. Tsirkin (1):
MAiNTAINERS: add Paolo, Stefan for virtio blk/scsi
MAINTAINERS | 15 ++++++++++++++-
drivers/virtio/virtio_pci_common.c | 8 +++++---
drivers/virtio/virtio_ring.c | 2 ++
include/linux/virtio_ring.h | 2 +-
4 files changed, 22 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-10 13:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 13:13 [PULL] virtio fixes Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2019-04-10 13:18 [PULL] virtio: fixes Michael S. Tsirkin
2019-02-06 19:32 Michael S. Tsirkin
2010-06-23 13:20 [PULL] virtio fixes Rusty Russell
[not found] <200910191301.24726.rusty@rustcorp.com.au>
2009-10-21 23:31 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0910220831090.9771@eeepc.linux-foundation.org>
2009-10-22 6:13 ` Rusty Russell
2009-10-19 2:31 Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).