From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
linux-pci@vger.kernel.org, Matt Carlson <mcarlson@broadcom.com>,
virtualization@lists.linux-foundation.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Bjorn@smtp1.linux-foundation.org,
Randy@smtp1.linux-foundation.org,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH for-2.6.35] virtio-pci: disable msi at startup
Date: Thu, 10 Jun 2010 08:34:32 -0700 [thread overview]
Message-ID: <20100610083432.3c23ad6a__7663.76869655705$1276184259$gmane$org@virtuousgeek.org> (raw)
In-Reply-To: <20100610152252.GA3510@redhat.com>
On Thu, 10 Jun 2010 18:22:52 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> virtio-pci resets the device at startup by writing to the status
> register, but this does not clear the pci config space,
> specifically msi enable status which affects register
> layout.
>
> This breaks things like kdump when they try to use e.g. virtio-blk.
>
> Fix by forcing msi off at startup. Since pci.c already has
> a routine to do this, we export and use it instead of duplicating code.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Tested-by: Vivek Goyal <vgoyal@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: linux-pci@vger.kernel.org
> ---
Yeah, looks fine.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next parent reply other threads:[~2010-06-10 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100610152252.GA3510@redhat.com>
2010-06-10 15:34 ` Jesse Barnes [this message]
2010-06-23 13:59 ` [PATCH for-2.6.35] virtio-pci: disable msi at startup Avi Kivity
2010-06-23 13:59 ` Michael S. Tsirkin
[not found] ` <20100623135946.GA30526@redhat.com>
2010-06-23 14:21 ` Avi Kivity
2010-06-23 14:43 ` Michael S. Tsirkin
[not found] ` <20100623144307.GB30526@redhat.com>
2010-06-23 15:15 ` Avi Kivity
[not found] ` <4C222508.2060804@redhat.com>
2010-06-23 15:26 ` Michael S. Tsirkin
[not found] ` <20100623152633.GC30526@redhat.com>
2010-06-23 15:35 ` Avi Kivity
[not found] ` <4C2229DB.6060706@redhat.com>
2010-06-23 15:43 ` Michael S. Tsirkin
2010-06-23 15:51 ` Jesse Barnes
[not found] ` <20100623154311.GD30526@redhat.com>
2010-06-23 15:53 ` Avi Kivity
2010-06-10 15:22 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20100610083432.3c23ad6a__7663.76869655705$1276184259$gmane$org@virtuousgeek.org' \
--to=jbarnes@virtuousgeek.org \
--cc=Bjorn@smtp1.linux-foundation.org \
--cc=Randy@smtp1.linux-foundation.org \
--cc=aliguori@us.ibm.com \
--cc=bjorn.helgaas@hp.com \
--cc=davem@davemloft.net \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mst@redhat.com \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).