From: Christoph Hellwig <hch@lst.de>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: john cooper <john.cooper@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Add 'serial' attribute to virtio-blk devices
Date: Mon, 21 Jun 2010 14:44:47 +0200 [thread overview]
Message-ID: <20100621124447.GA8166@lst.de> (raw)
In-Reply-To: <1276886283-1571-1-git-send-email-ryanh@us.ibm.com>
On Fri, Jun 18, 2010 at 01:38:02PM -0500, Ryan Harper wrote:
> Create a new attribute for virtio-blk devices that will fetch the serial number
> of the block device. This attribute can be used by udev to create disk/by-id
> symlinks for devices that don't have a UUID (filesystem) associated with them.
>
> ATA_IDENTIFY strings are special in that they can be up to 20 chars long
> and aren't required to be NULL-terminated. The buffer is also zero-padded
> meaning that if the serial is 19 chars or less that we get a NULL terminated
> string. When copying this value into a string buffer, we must be careful to
> copy up to the NULL (if it present) and only 20 if it is longer and not to
> attempt to NULL terminate; this isn't needed.
Why is this virtio-blk specific? In a later mail you mention you want
to use it for udev. So please export this from scsi/libata as well and
we have one proper interface that we can use for all devices.
next prev parent reply other threads:[~2010-06-21 12:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1276886283-1571-1-git-send-email-ryanh@us.ibm.com>
2010-06-18 18:38 ` [PATCH 2/2] Remove virtio_blk VBID ioctl Ryan Harper
2010-06-19 8:24 ` [Qemu-devel] [PATCH 1/2] Add 'serial' attribute to virtio-blk devices Blue Swirl
[not found] ` <AANLkTin7WwGhL-O4ENzG6u-2q0pYiLpyH1tfzLUxK4PQ@mail.gmail.com>
2010-06-19 10:58 ` Ulrich Drepper
[not found] ` <4C1CA2DB.2080502@redhat.com>
2010-06-19 15:59 ` Blue Swirl
[not found] ` <1276886283-1571-2-git-send-email-ryanh@us.ibm.com>
2010-06-21 1:30 ` [PATCH 2/2] Remove virtio_blk VBID ioctl Rusty Russell
[not found] ` <201006211100.19719.rusty@rustcorp.com.au>
2010-06-21 2:30 ` Ryan Harper
2010-06-21 5:07 ` john cooper
2010-06-21 1:52 ` [PATCH 1/2] Add 'serial' attribute to virtio-blk devices Rusty Russell
[not found] ` <201006211122.38156.rusty@rustcorp.com.au>
2010-06-21 5:51 ` john cooper
[not found] ` <4C1EFDFD.5050907@redhat.com>
2010-06-21 16:43 ` Ryan Harper
[not found] ` <20100621164321.GF1647@us.ibm.com>
2010-06-21 17:11 ` john cooper
2010-06-21 23:25 ` Rusty Russell
[not found] ` <201006220855.21925.rusty@rustcorp.com.au>
2010-06-22 3:40 ` john cooper
2010-06-21 12:44 ` Christoph Hellwig [this message]
2010-06-21 16:45 ` [Qemu-devel] " Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621124447.GA8166@lst.de \
--to=hch@lst.de \
--cc=john.cooper@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).