Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

[Greg KH]

On Mon, Aug 02, 2010 at 05:00:33PM +0000, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
> 
> Subject: staging: hv: Fix missing functions for net_device_ops
>   Unlike in older kernels, ether_setup() no longer sets default
> functions.

So what kernel versions are affected by this?

Please don't attach a patch and put it inline, it forces me to edit it
by hand.

Care to provide the above information and resend it so I can apply it?

thanks,

greg k-h

RE: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

[Haiyang Zhang]

> From: Greg KH [mailto:gregkh@suse.de]
> Sent: Monday, August 02, 2010 1:18 PM
>
> So what kernel versions are affected by this?
> 
> Please don't attach a patch and put it inline, it forces me to edit it
> by hand.
> 
> Care to provide the above information and resend it so I can apply it?

It affects kernel 2.6.32 and later, which are all versions contain Hyper-V drivers.
I will send out an email with the inline patch only.

Thanks,

- Haiyang

[PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

[Haiyang Zhang]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

From: Haiyang Zhang <haiyangz@microsoft.com>

Subject: staging: hv: Fix missing functions for net_device_ops
  Unlike in older kernels, ether_setup() no longer sets default
functions. We need to put them into net_device_ops. For example,
eth_change_mtu prevents setting MTU beyond 1500. This is necessary
because we don't support jumbo frame at this time.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>

---
 drivers/staging/hv/netvsc_drv.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 56e1157..64a0114 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -327,6 +327,9 @@ static const struct net_device_ops device_ops = {
 	.ndo_stop =			netvsc_close,
 	.ndo_start_xmit =		netvsc_start_xmit,
 	.ndo_set_multicast_list =	netvsc_set_multicast_list,
+	.ndo_change_mtu =		eth_change_mtu,
+	.ndo_validate_addr =		eth_validate_addr,
+	.ndo_set_mac_address =		eth_mac_addr,
 };
 
 static int netvsc_probe(struct device *device)
-- 
1.6.3.2


[-- Attachment #2: 0729-fix-missing-functions-for-net_device_ops.patch --]
[-- Type: application/octet-stream, Size: 1131 bytes --]

From: Haiyang Zhang <haiyangz@microsoft.com>

Subject: staging: hv: Fix missing functions for net_device_ops
  Unlike in older kernels, ether_setup() no longer sets default
functions. We need to put them into net_device_ops. For example,
eth_change_mtu prevents setting MTU beyond 1500. This is necessary
because we don't support jumbo frame at this time.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>

---
 drivers/staging/hv/netvsc_drv.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 56e1157..64a0114 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -327,6 +327,9 @@ static const struct net_device_ops device_ops = {
 	.ndo_stop =			netvsc_close,
 	.ndo_start_xmit =		netvsc_start_xmit,
 	.ndo_set_multicast_list =	netvsc_set_multicast_list,
+	.ndo_change_mtu =		eth_change_mtu,
+	.ndo_validate_addr =		eth_validate_addr,
+	.ndo_set_mac_address =		eth_mac_addr,
 };
 
 static int netvsc_probe(struct device *device)
-- 
1.6.3.2


[-- Attachment #3: Type: text/plain, Size: 184 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization