From: Jens Osterkamp <jens@linux.vnet.ibm.com>
To: John Fastabend <john.r.fastabend@intel.com>
Cc: "chrisw@redhat.com" <chrisw@redhat.com>,
arnd@arndb.de, Stefan Berger <stefanb@linux.vnet.ibm.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Gerhard Stenzel <gstenzel@linux.vnet.ibm.com>,
"evb@yahoogroups.com" <evb@yahoogroups.com>,
"e1000-eedc@lists.sourceforge.net"
<e1000-eedc@lists.sourceforge.net>
Subject: Re: [E1000-eedc] [PATCH 16/17] lldpad support for libvirt netlink message
Date: Tue, 3 Aug 2010 13:59:54 +0200 [thread overview]
Message-ID: <201008031359.54190.jens@linux.vnet.ibm.com> (raw)
In-Reply-To: <4C57CACE.2070202@intel.com>
On Tuesday 03 August 2010, John Fastabend wrote:
> Jens Osterkamp wrote:
> > This code receives a IEEE 802.1Qbg virtual station instance from libvirt in
> > a SETLINK message. The parsed VSI is then handed over to VDP for processing.
> > The VDP state machine processes the VSI while libvirt polls the result using
> > GETLINK.
> >
> > Requires at least Linux kernel 2.6.35-rc1.
> >
> > Signed-off-by: Jens Osterkamp <jens@linux.vnet.ibm.com>
> > Signed-off-by: Gerhard Stenzel <gstenzel@linux.vnet.ibm.com>
> > Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> > ---
> > event_iface.c | 617 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > lldp_vdp.c | 2 +-
> > lldpad.c | 10 +
> > 3 files changed, 622 insertions(+), 7 deletions(-)
> >
>
> Jens,
>
> Can you explain why this interface is needed? There is already a kernel
We needed a way in libvirt to associate the virtual network interface(s) of a
guest with an adjacent switch. The protocol to do this could be implemented
both in userspace (e.g. in lldpad) or in the adapter firmware. You could have
different drivers for both ways in libvirt but to keep it simple we decided
to use netlink for both.
The original mailthread on netdev started here
http://marc.info/?l=linux-netdev&m=127242976205746&w=2
> interface for this how come libvirt and lldpad can not use the kernel interface?
In fact we are using the kernel interface for this, e.g. the definitions of the
netlink attributes are in the kernel header files.
The only difference is that in the userspace case, the netlink messages
are addressed to the pid of lldpad whereas in the firmware case, the netlink
messages go to pid 0 (kernel).
Best regards,
Jens Osterkamp
--------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2010-08-03 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:34 implementation of IEEE 802.1Qbg in lldpad Jens Osterkamp
2010-07-23 10:34 ` [PATCH 01/17] consolidation of MIN and MAX macros in common.h Jens Osterkamp
2010-07-23 10:34 ` [PATCH 02/17] implementation of IEEE 802.1Qbg in lldpad, part 1 Jens Osterkamp
2010-07-23 10:34 ` [PATCH 03/17] support for getting and setting EVB TLV parameters Jens Osterkamp
2010-07-23 10:34 ` [PATCH 04/17] BUGFIX: check in correct positions Jens Osterkamp
2010-07-23 10:34 ` [PATCH 05/17] remove VDPL and proper config save and restore Jens Osterkamp
2010-07-23 10:34 ` [PATCH 06/17] BUGFIX: agree to max of rte Jens Osterkamp
2010-07-23 10:34 ` [PATCH 07/17] BUGFIX: avoid compile warnings Jens Osterkamp
2010-07-23 10:34 ` [PATCH 08/17] BUGFIX: fix formatting in include/lldp_evb_clif.h Jens Osterkamp
2010-07-23 10:34 ` [PATCH 09/17] BUGFIX: check for existence of ifup Jens Osterkamp
2010-07-23 10:34 ` [PATCH 10/17] allow to set both supported forwarding modes Jens Osterkamp
2010-07-23 10:34 ` [PATCH 11/17] ECP implementation Jens Osterkamp
2010-08-03 6:36 ` [E1000-eedc] " John Fastabend
2010-08-03 12:02 ` Jens Osterkamp
2010-07-23 10:34 ` [PATCH 12/17] implementation of vdp Jens Osterkamp
2010-07-23 10:34 ` [PATCH 13/17] VDP commandline interface Jens Osterkamp
2010-07-23 10:34 ` [PATCH 14/17] add libnl dependency to configure.ac Jens Osterkamp
2010-07-23 10:34 ` [PATCH 15/17] use connect instead of bind Jens Osterkamp
2010-07-23 10:34 ` [PATCH 16/17] lldpad support for libvirt netlink message Jens Osterkamp
2010-08-03 7:52 ` [E1000-eedc] " John Fastabend
2010-08-03 11:59 ` Jens Osterkamp [this message]
2010-07-23 10:34 ` [PATCH 17/17] do not use macv[tap/lan] interfaces as ports Jens Osterkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008031359.54190.jens@linux.vnet.ibm.com \
--to=jens@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=chrisw@redhat.com \
--cc=e1000-eedc@lists.sourceforge.net \
--cc=evb@yahoogroups.com \
--cc=gstenzel@linux.vnet.ibm.com \
--cc=john.r.fastabend@intel.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).