[PATCH 4/6] staging: hv: Removed TODO for VMBUS, it mirrors HYPER-V behavior to closely

[PATCH 4/6] staging: hv: Removed TODO for VMBUS, it mirrors HYPER-V behavior to closely

[Hank Janssen]

From: Hank Janssen <hjanssen@microsoft.com>

Removed TODO for VMBUS, it mirrors HYPER-V behaviour to closely and does not really share any 
usable functionality of the Linux kernel facilities. There is not really an easy way to combine functionality.

Signed-off-by:Hank Janssen <hjanssen@microsoft.com>
Signed-off-by:Haiyang Zhang <haiyangz@microsoft.com>

---
 drivers/staging/hv/TODO |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/hv/TODO b/drivers/staging/hv/TODO index 66a89c8..8ca2947 100644
--- a/drivers/staging/hv/TODO
+++ b/drivers/staging/hv/TODO
@@ -4,8 +4,6 @@ TODO:
 	  driver model
 	- convert vmbus driver interface function pointer tables
           to constant, a.k.a vmbus_ops
-	- see if the vmbus can be merged with the other virtual busses
-	  in the kernel
 	- audit the network driver
 	  - checking for carrier inside open is wrong, network device API
             confusion??
--
1.6.0.2

Re: [PATCH 4/6] staging: hv: Removed TODO for VMBUS, it mirrors HYPER-V behavior to closely

[Greg KH]

On Tue, Aug 03, 2010 at 05:31:54PM +0000, Hank Janssen wrote:
> From: Hank Janssen <hjanssen@microsoft.com>
> 
> Removed TODO for VMBUS, it mirrors HYPER-V behaviour to closely and does not really share any 
> usable functionality of the Linux kernel facilities. There is not really an easy way to combine functionality.

Are you sure about that?  Right now, the code doesn't look like any
other virtual bus code, but that's because it needs to be fixed up and
work properly (not with the two layers of indirection that was added a
long time ago before the code was opened up.)

I think once the code is cleaned up properly, you might find that it can
be combined much easier than you think...

So no, I'll not allow this TODO item to be removed until after the vbus
code is fixed up, and you can convince me that it really is unique
enough to remain as-is.

Oh, and again, please properly line-wrap your changelog comments.

thanks,

greg k-h