Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

[Greg KH]

On Mon, Aug 02, 2010 at 05:46:01PM +0000, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
> 
> Subject: staging: hv: Fix missing functions for net_device_ops
>   Unlike in older kernels, ether_setup() no longer sets default

Why put the subject in the body of the email?  This forces me to edit it
again :(

> functions. We need to put them into net_device_ops. For example,
> eth_change_mtu prevents setting MTU beyond 1500. This is necessary
> because we don't support jumbo frame at this time.

What does this mean?  Is it a bug?  Just not going as fast as possible?
Something else?

>   It affects kernel 2.6.32 and later, which are all versions
> containing Hyper-V drivers.

So is this fixing a bug that needs to be backported to these older
kernels (i.e. the staging tree?)  Is this something that is causing
people problems?

Third time's a charm?

thanks,

greg k-h

RE: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

[Haiyang Zhang]

> From: Greg KH [mailto:greg@kroah.com]
> Sent: Monday, August 02, 2010 9:30 PM
> Why put the subject in the body of the email?  This forces me to edit
> it again :(

Sure, I'll remove it.

> > functions. We need to put them into net_device_ops. For example,
> > eth_change_mtu prevents setting MTU beyond 1500. This is necessary
> > because we don't support jumbo frame at this time.
> 
> What does this mean?  Is it a bug?  Just not going as fast as possible?
> Something else?

Yes, it's a bug when porting Linux IC from 2.6.27 to 2.6.32. In 2.6.27,
the default functions for Ethernet, like eth_change_mtu(), were assigned
by ether_setup(). But in 2.6.32, these function pointers moved to
net_device_ops structure and no longer be assigned in ether_setup(). So we
need to set these functions in our driver code. It will ensure the MTU won't
be set beyong 1500. Otherwise, this can cause an error on the server side,
because the HyperV linux driver doesn't support jumbo frame yet.

> >   It affects kernel 2.6.32 and later, which are all versions
> > containing Hyper-V drivers.
> 
> So is this fixing a bug that needs to be backported to these older
> kernels (i.e. the staging tree?)  Is this something that is causing
> people problems?

Yes it should be backported. The bug can cause error on guest and host.

Thanks,

- Haiyang

Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

[Greg KH]

On Tue, Aug 03, 2010 at 06:21:50PM +0000, Haiyang Zhang wrote:
> > From: Greg KH [mailto:greg@kroah.com]
> > Sent: Monday, August 02, 2010 9:30 PM
> > Why put the subject in the body of the email?  This forces me to edit
> > it again :(
> 
> Sure, I'll remove it.

thanks.

> > > functions. We need to put them into net_device_ops. For example,
> > > eth_change_mtu prevents setting MTU beyond 1500. This is necessary
> > > because we don't support jumbo frame at this time.
> > 
> > What does this mean?  Is it a bug?  Just not going as fast as possible?
> > Something else?
> 
> Yes, it's a bug when porting Linux IC from 2.6.27 to 2.6.32. In 2.6.27,
> the default functions for Ethernet, like eth_change_mtu(), were assigned
> by ether_setup(). But in 2.6.32, these function pointers moved to
> net_device_ops structure and no longer be assigned in ether_setup(). So we
> need to set these functions in our driver code. It will ensure the MTU won't
> be set beyong 1500. Otherwise, this can cause an error on the server side,
> because the HyperV linux driver doesn't support jumbo frame yet.

Wonderful, why not put this type of full information in the patch itself
so that people can understand and rememeber what is going on when they
look at it in a few months time?

> > >   It affects kernel 2.6.32 and later, which are all versions
> > > containing Hyper-V drivers.
> > 
> > So is this fixing a bug that needs to be backported to these older
> > kernels (i.e. the staging tree?)  Is this something that is causing
> > people problems?
> 
> Yes it should be backported. The bug can cause error on guest and host.

Than please ask for it to be backported in the future.

thanks,

greg k-h

[PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

[Haiyang Zhang]

From: Haiyang Zhang <haiyangz@microsoft.com>

Subject: staging: hv: Fix missing functions for net_device_ops
  Unlike in older kernels, ether_setup() no longer sets default
functions. We need to put them into net_device_ops. For example,
eth_change_mtu prevents setting MTU beyond 1500. This is necessary
because we don't support jumbo frame at this time.
  It affects kernel 2.6.32 and later, which are all versions
containing Hyper-V drivers.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>

---
 drivers/staging/hv/netvsc_drv.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 56e1157..64a0114 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -327,6 +327,9 @@ static const struct net_device_ops device_ops = {
 	.ndo_stop =			netvsc_close,
 	.ndo_start_xmit =		netvsc_start_xmit,
 	.ndo_set_multicast_list =	netvsc_set_multicast_list,
+	.ndo_change_mtu =		eth_change_mtu,
+	.ndo_validate_addr =		eth_validate_addr,
+	.ndo_set_mac_address =		eth_mac_addr,
 };
 
 static int netvsc_probe(struct device *device)
-- 
1.6.3.2