From: Greg KH <gregkh@suse.de>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'devel@driverdev.osuosl.org'" <devel@driverdev.osuosl.org>,
"'virtualization@lists.osdl.org'" <virtualization@lists.osdl.org>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 3/6] staging: hv: Fixed the value of the 64bit-hole inside ring buffer
Date: Wed, 4 Aug 2010 10:05:24 -0700 [thread overview]
Message-ID: <20100804170524.GC28217@suse.de> (raw)
In-Reply-To: <8AFC7968D54FB448A30D8F38F259C56223FE7ADB@TK5EX14MBXC114.redmond.corp.microsoft.com>
On Wed, Aug 04, 2010 at 04:25:40AM +0000, Hank Janssen wrote:
>
> >>On Tue, Aug 03, 2010 at 05:31:57PM +0000, Hank Janssen wrote:
> >> From: Haiyang Zhang <haiyangz@microsoft.com>
> >>
> >> Fixed the value of the 64bit-hole inside ring buffer, this caused a problem on Hyper-V
> >>when running checked Windows builds.
> >
> >What was the problem, and why would this fix it? Was it a bug in this code,
> >by virtue that the code was incorrect in the client and the checked builds properly warned
> >of this, or something else?
>
> Checked builds of Windows are used internally and given to external system builders at times.
> They are builds that for example that all elements in a structure follow the definition of that
> Structure. The bug this fixed was for a field that we did not fill in at all (Because we do
> Not use it on the Linux side), and the checked build of windows gives errors on it internally
> to the Windows logs.
>
> This fixes that error.
Wonderful, please provide this information in the changelog comment.
thanks,
greg k-h
prev parent reply other threads:[~2010-08-04 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 17:31 [PATCH 3/6] staging: hv: Fixed the value of the 64bit-hole inside ring buffer Hank Janssen
2010-08-03 17:44 ` Greg KH
2010-08-04 4:25 ` Hank Janssen
2010-08-04 17:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804170524.GC28217@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).