From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 02/14] virtio: console: Remove control vq data only if using multiport support
Date: Mon, 6 Sep 2010 17:59:39 +0930 [thread overview]
Message-ID: <201009061759.40423.rusty@rustcorp.com.au> (raw)
In-Reply-To: <c7259c88e3dc036806629cd31f08e8b54fa1c345.1283430900.git.amit.shah@redhat.com>
On Thu, 2 Sep 2010 10:11:41 pm Amit Shah wrote:
> If a portdev isn't using multiport support, it won't have any control vq
> data to remove.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
So previously it would crash if it was ever removed? If so, it'd be
nice to see that in the patch description :)
Thanks,
Rusty.
next prev parent reply other threads:[~2010-09-06 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 12:41 [PATCH 00/14] virtio: console: Hot-unplug fixes Amit Shah
2010-09-02 12:41 ` [PATCH 01/14] virtio: console: Reset vdev before removing device Amit Shah
2010-09-02 12:41 ` [PATCH 02/14] virtio: console: Remove control vq data only if using multiport support Amit Shah
2010-09-06 8:29 ` Rusty Russell [this message]
2010-09-06 10:22 ` Amit Shah
2010-09-02 12:41 ` [PATCH 03/14] virtio: console: Check if portdev is valid in send_control_msg() Amit Shah
2010-09-02 12:41 ` [PATCH 04/14] virtio: console: Un-block reads on chardev close Amit Shah
2010-09-02 12:41 ` [PATCH 05/14] virtio: console: Unblock poll on port hot-unplug Amit Shah
2010-09-02 12:41 ` [PATCH 06/14] virtio: console: Make read() return -ENODEV on hot-unplug Amit Shah
2010-09-02 12:41 ` [PATCH 07/14] virtio: console: Make write() " Amit Shah
2010-09-02 12:41 ` [PATCH 08/14] virtio: console: remove_port() should return void Amit Shah
2010-09-02 12:41 ` [PATCH 09/14] virtio: console: open: Use a common path for error handling Amit Shah
2010-09-02 12:41 ` [PATCH 10/14] virtio: console: Add a list of portdevs that are active Amit Shah
2010-09-02 12:50 ` [PATCH 11/14] virtio: console: Add a find_port_by_devt() function Amit Shah
2010-09-02 12:50 ` [PATCH 12/14] virtio: console: Use cdev_alloc() instead of cdev_init() Amit Shah
2010-09-02 13:08 ` [PATCH 13/14] virtio: console: Add reference counting for port struct Amit Shah
2010-09-02 13:08 ` [PATCH 14/14] virtio: console: Reference counting portdev structs is not needed Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009061759.40423.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).