From: Greg KH <greg@kroah.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>
Subject: Re: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases
Date: Wed, 3 Nov 2010 04:36:03 -0700 [thread overview]
Message-ID: <20101103113603.GA13276@kroah.com> (raw)
In-Reply-To: <1FB5E1D5CA062146B38059374562DF728BA55BD7@TK5EX14MBXC126.redmond.corp.microsoft.com>
On Tue, Nov 02, 2010 at 09:06:56PM +0000, Haiyang Zhang wrote:
> > From: Brandon Philips [mailto:brandon@ifup.org]
> > Sent: Tuesday, November 02, 2010 1:04 PM
> > > -static int HvQueryHypervisorInfo(void)
> > > +static int hvquery_hypervisor_info(void)
> > > -static u64 HvDoHypercall(u64 control, void *input, void *output)
> > > +static u64 hvdo_hypercall(u64 control, void *input, void *output)
> >
> > Should these be hv_do_hypercall and hv_query_hypervisor? That seems to
> > be the style in the rest of the patch:
>
> I didn't insert underscore between every word, for example, it's not
> added between two short words.
But you should. Remember, be consistent.
Care to redo these again?
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-03 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 20:46 [PATCH 01/10] staging: hv: Convert camel cased struct fields in channel_mgmt.h to lower cases Haiyang Zhang
2010-11-01 20:46 ` [PATCH 02/10] staging: hv: Convert camel cased struct fields in hv_api.h " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 04/10] staging: hv: Convert camel cased local variables in hv.c " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 05/10] staging: hv: Convert camel cased functions " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 06/10] staging: hv: Convert camel cased local variables in osd.c " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 07/10] staging: hv: Convert camel cased functions " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 08/10] staging: hv: Convert camel cased struct fields in ring_buffer.h " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 09/10] staging: hv: Convert camel cased local variables in ring_buffer.c " Haiyang Zhang
2010-11-01 20:46 ` [PATCH 10/10] staging: hv: Convert camel cased functions " Haiyang Zhang
2010-11-02 17:04 ` [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c " Brandon Philips
2010-11-02 21:06 ` Haiyang Zhang
2010-11-03 11:36 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-08 22:04 [PATCH 01/10] staging: hv: Convert camel cased struct fields in channel_mgmt.h " Haiyang Zhang
2010-11-08 22:04 ` [PATCH 02/10] staging: hv: Convert camel cased struct fields in hv_api.h " Haiyang Zhang
2010-11-08 22:04 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
2010-11-08 22:04 ` [PATCH 04/10] staging: hv: Convert camel cased local variables in hv.c " Haiyang Zhang
2010-11-08 22:04 ` [PATCH 05/10] staging: hv: Convert camel cased functions " Haiyang Zhang
2010-11-03 23:14 Haiyang Zhang
2010-11-01 16:31 [PATCH 01/10] staging: hv: Convert camel cased struct fields in channel_mgmt.h " Haiyang Zhang
2010-11-01 16:31 ` [PATCH 02/10] staging: hv: Convert camel cased struct fields in hv_api.h " Haiyang Zhang
2010-11-01 16:31 ` [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h " Haiyang Zhang
2010-11-01 16:31 ` [PATCH 04/10] staging: hv: Convert camel cased local variables in hv.c " Haiyang Zhang
2010-11-01 16:31 ` [PATCH 05/10] staging: hv: Convert camel cased functions " Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103113603.GA13276@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).