From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Greg KH <greg@kroah.com>,
virtualization@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio: fix format of sysfs driver/vendor files
Date: Wed, 10 Nov 2010 23:21:25 +1030 [thread overview]
Message-ID: <201011102321.26288.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20101109222029.65f3e192@nehalam>
On Wed, 10 Nov 2010 04:50:29 pm Stephen Hemminger wrote:
> The sysfs files for virtio produce the wrong format and are missing
> the required newline. The output for virtio bus vendor/device should
> have the same format as the corresponding entries for PCI devices.
>
> Although this technically changes the ABI for sysfs, these files were
> broken to start with!
Agreed, and I don't think anyone currently uses them.
Applied,
Rusty.
prev parent reply other threads:[~2010-11-10 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 6:20 [PATCH] virtio: fix format of sysfs driver/vendor files Stephen Hemminger
2010-11-10 12:51 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011102321.26288.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).