* [PATCH 1/3]: An implementation of HyperV KVP functionality
@ 2010-11-22 20:21 Ky Srinivasan
0 siblings, 0 replies; 5+ messages in thread
From: Ky Srinivasan @ 2010-11-22 20:21 UTC (permalink / raw)
To: devel, Virtualization; +Cc: Zbr, Haiyang Zhang, Stephen Hemminger, Greg KH
From: K. Y. Srinivasan <ksrinivasan@novell.com>
Subject: Reserve a connector index for implementing HyperV Key Value Pair
(KVP) functionality.
Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
Index: linux.trees.git/include/linux/connector.h
===================================================================
--- linux.trees.git.orig/include/linux/connector.h 2010-11-15 06:50:30.000000000 -0500
+++ linux.trees.git/include/linux/connector.h 2010-11-15 07:00:52.000000000 -0500
@@ -42,8 +42,9 @@
#define CN_VAL_DM_USERSPACE_LOG 0x1
#define CN_IDX_DRBD 0x8
#define CN_VAL_DRBD 0x1
+#define CN_KVP_IDX 0x9 /* HyperV KVP */
-#define CN_NETLINK_USERS 8
+#define CN_NETLINK_USERS 9
/*
* Maximum connector's message size.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3]: An implementation of HyperV KVP functionality
@ 2010-12-07 22:09 Ky Srinivasan
2010-12-07 23:10 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Ky Srinivasan @ 2010-12-07 22:09 UTC (permalink / raw)
To: devel, Virtualization; +Cc: Zbr, Haiyang Zhang, Stephen Hemminger, Greg KH
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
This patch is re-based on the latest linux-next tree.
From: K. Y. Srinivasan <ksrinivasan@novell.com>
Subject: Reserve a connector index for implementing HyperV Key Value Pair
(KVP) functionality.
Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
Index: linux.trees.git/include/linux/connector.h
===================================================================
--- linux.trees.git.orig/include/linux/connector.h 2010-11-05 16:45:32.000000000 -0400
+++ linux.trees.git/include/linux/connector.h 2010-12-07 06:58:34.000000000 -0500
@@ -42,8 +42,9 @@
#define CN_VAL_DM_USERSPACE_LOG 0x1
#define CN_IDX_DRBD 0x8
#define CN_VAL_DRBD 0x1
+#define CN_KVP_IDX 0x9 /* HyperV KVP */
-#define CN_NETLINK_USERS 8
+#define CN_NETLINK_USERS 9
/*
* Maximum connector's message size.
[-- Attachment #2: kvp_connector.patch --]
[-- Type: text/plain, Size: 766 bytes --]
From: K. Y. Srinivasan <ksrinivasan@novell.com>
Subject: Reserve a connector index for implementing HyperV Key Value Pair
(KVP) functionality.
Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
Index: linux.trees.git/include/linux/connector.h
===================================================================
--- linux.trees.git.orig/include/linux/connector.h 2010-11-05 16:45:32.000000000 -0400
+++ linux.trees.git/include/linux/connector.h 2010-12-07 06:58:34.000000000 -0500
@@ -42,8 +42,9 @@
#define CN_VAL_DM_USERSPACE_LOG 0x1
#define CN_IDX_DRBD 0x8
#define CN_VAL_DRBD 0x1
+#define CN_KVP_IDX 0x9 /* HyperV KVP */
-#define CN_NETLINK_USERS 8
+#define CN_NETLINK_USERS 9
/*
* Maximum connector's message size.
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3]: An implementation of HyperV KVP functionality
2010-12-07 22:09 [PATCH 1/3]: An implementation of HyperV KVP functionality Ky Srinivasan
@ 2010-12-07 23:10 ` Greg KH
2010-12-08 21:31 ` Ky Srinivasan
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2010-12-07 23:10 UTC (permalink / raw)
To: Ky Srinivasan
Cc: devel, Haiyang Zhang, Virtualization, Zbr, Stephen Hemminger
On Tue, Dec 07, 2010 at 03:09:52PM -0700, Ky Srinivasan wrote:
> This patch is re-based on the latest linux-next tree.
>
> From: K. Y. Srinivasan <ksrinivasan@novell.com>
> Subject: Reserve a connector index for implementing HyperV Key Value Pair
> (KVP) functionality.
A hint, this is not how you submit a patch. Please put the Subject line
up above in the real Subject for the email.
Also provide a bit of a description in the body of the email that
explains what is going on.
>
> Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
>
> Index: linux.trees.git/include/linux/connector.h
> ===================================================================
What are these lines from? Surely you aren't using cvs these days, are
you?
I should be able to take the email and directly feed it to 'git am' to
apply it, without editing it at all.
Care to fix this, and address the connector issues, and then resend them
all?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3]: An implementation of HyperV KVP functionality
2010-12-07 23:10 ` Greg KH
@ 2010-12-08 21:31 ` Ky Srinivasan
2010-12-08 21:44 ` Evgeniy Polyakov
0 siblings, 1 reply; 5+ messages in thread
From: Ky Srinivasan @ 2010-12-08 21:31 UTC (permalink / raw)
To: Greg KH; +Cc: devel, Zbr, Haiyang Zhang, Stephen Hemminger, Virtualization
>
> Care to fix this, and address the connector issues, and then resend them
> all?
Evgeniy has acked the patch for adding a new connector index for implementing the KVP functionality. The concern Evgeniy had was with regards to the code currently in the upstream tree and Hank is planning to submit a patch to fix that issue.
Regards,
K. Y
>
> thanks,
>
> greg k-h
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3]: An implementation of HyperV KVP functionality
2010-12-08 21:31 ` Ky Srinivasan
@ 2010-12-08 21:44 ` Evgeniy Polyakov
0 siblings, 0 replies; 5+ messages in thread
From: Evgeniy Polyakov @ 2010-12-08 21:44 UTC (permalink / raw)
To: Ky Srinivasan
Cc: devel, Virtualization, Haiyang Zhang, Greg KH, Stephen Hemminger
On Wed, Dec 08, 2010 at 02:31:47PM -0700, Ky Srinivasan (ksrinivasan@novell.com) wrote:
> > Care to fix this, and address the connector issues, and then resend them
> > all?
>
> Evgeniy has acked the patch for adding a new connector index for implementing the KVP functionality. The concern Evgeniy had was with regards to the code currently in the upstream tree and Hank is planning to submit a patch to fix that issue.
Connector is ok, but rest of the code looks wrong sometimes,
so please resumbit the whole series with proper descriptions
and subject lines.
Thank you.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-08 21:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-07 22:09 [PATCH 1/3]: An implementation of HyperV KVP functionality Ky Srinivasan
2010-12-07 23:10 ` Greg KH
2010-12-08 21:31 ` Ky Srinivasan
2010-12-08 21:44 ` Evgeniy Polyakov
-- strict thread matches above, loose matches on Subject: below --
2010-11-22 20:21 Ky Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).