From: Greg KH <gregkh@suse.de>
To: Ky Srinivasan <ksrinivasan@novell.com>
Cc: devel@driverdev.osuosl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Virtualization@lists.osdl.org, Zbr@ioremap.net,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 2/3]: An implementation of HyperV KVP functionality
Date: Tue, 7 Dec 2010 15:12:54 -0800 [thread overview]
Message-ID: <20101207231254.GA27988@suse.de> (raw)
In-Reply-To: <4CFE5204020000300009174C@novprvoes0310.provo.novell.com>
On Tue, Dec 07, 2010 at 03:25:56PM -0700, Ky Srinivasan wrote:
> This patch is re-based on the latest linux-next tree.
>
> From: K. Y. Srinivasan <ksrinivasan@novell.com>
>
> Subject: The hv_utils module will be composed of more than one file;
> rename hv_utils.c to accommodate this without changing the module name.
>
> Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
>
Please put the diffstat of the patch in below the signed-off-by: and
after a --- line.
> Index: linux.trees.git/drivers/staging/hv/Makefile
> ===================================================================
> --- linux.trees.git.orig/drivers/staging/hv/Makefile 2010-12-07 07:04:41.000000000 -0500
> +++ linux.trees.git/drivers/staging/hv/Makefile 2010-12-07 08:00:10.000000000 -0500
> @@ -10,3 +10,4 @@ hv_vmbus-y := vmbus_drv.o osd.o \
> hv_storvsc-y := storvsc_drv.o storvsc.o
> hv_blkvsc-y := blkvsc_drv.o blkvsc.o
> hv_netvsc-y := netvsc_drv.o netvsc.o rndis_filter.o
> +hv_utils-y := hv_util.o
> Index: linux.trees.git/drivers/staging/hv/hv_util.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux.trees.git/drivers/staging/hv/hv_util.c 2010-12-07 08:00:10.000000000 -0500
Are you renaming the file here? Are you using git? If so, it should
produce a patch that shows the rename happened, not this big 'remove it
all and then add it back' type thing.
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-07 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 22:25 [PATCH 2/3]: An implementation of HyperV KVP functionality Ky Srinivasan
2010-12-07 22:29 ` Evgeniy Polyakov
2010-12-07 23:19 ` Ky Srinivasan
2010-12-08 18:09 ` Hank Janssen
2010-12-07 23:12 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-22 20:27 [PATCH 2/3]: An Implementation " Ky Srinivasan
2010-11-24 14:56 ` Evgeniy Polyakov
2010-11-29 18:26 ` Ky Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207231254.GA27988@suse.de \
--to=gregkh@suse.de \
--cc=Virtualization@lists.osdl.org \
--cc=Zbr@ioremap.net \
--cc=devel@driverdev.osuosl.org \
--cc=haiyangz@microsoft.com \
--cc=ksrinivasan@novell.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).