virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Ky Srinivasan <ksrinivasan@novell.com>
Cc: devel@driverdev.osuosl.org,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Virtualization@lists.osdl.org, Zbr@ioremap.net,
	Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 3/4] An Implementation of KVP functionality
Date: Wed, 8 Dec 2010 14:35:44 -0800	[thread overview]
Message-ID: <20101208223544.GC6714@suse.de> (raw)
In-Reply-To: <4CFFA47602000030000918D7@novprvoes0310.provo.novell.com>

How about:
	Subject: [PATCH 3/4] Staging: hv: implement key/value pair functionality

On Wed, Dec 08, 2010 at 03:29:58PM -0700, Ky Srinivasan wrote:
> >From 2843393e8f50421e81e033806cd121cfb8cc7b6a Mon Sep 17 00:00:00 2001
> From: ksrinivasan <ksrinivasan@novell.com>
> Date: Wed, 8 Dec 2010 13:46:46 -0700

Again, this doesn't belong in the patch body.  Use git send-email to
send patches out properly.

> 
>  
> This is an implementation of the key/value pair (KVP) functionality 
> for Linux guests hosted on HyperV. All guest specific data gathering for 
> KVP will be implemented in a user-level daemon. This kernel component packaged
> as part of the hv_utils driver supports communication with the HyperV 
> host. 

You have trailing spaces in your changelog comment.  Please fix your
editor to highlight stuff like this.

> 
> 
> 
> Signed-off-by: ksrinivasan <ksrinivasan@novell.com>

Again, wrong name :(

      reply	other threads:[~2010-12-08 22:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 22:29 [PATCH 3/4] An Implementation of KVP functionality Ky Srinivasan
2010-12-08 22:35 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208223544.GC6714@suse.de \
    --to=gregkh@suse.de \
    --cc=Virtualization@lists.osdl.org \
    --cc=Zbr@ioremap.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=haiyangz@microsoft.com \
    --cc=ksrinivasan@novell.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).