From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize Date: Tue, 14 Dec 2010 01:03:33 +0300 Message-ID: <20101213220333.GA1636@ioremap.net> References: <1292274861-29673-1-git-send-email-hjanssen@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1292274861-29673-1-git-send-email-hjanssen@microsoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Hank Janssen Cc: Haiyang Zhang , gregkh@suse.de, linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, Jesper Juhl , devel@linuxdriverproject.org, Ky Srinivasan List-Id: virtualization@lists.linuxfoundation.org On Mon, Dec 13, 2010 at 01:14:21PM -0800, Hank Janssen (hjanssen@microsoft.com) wrote: > +static u8 *shut_txf_buf; > +static u8 *time_txf_buf; > +static u8 *hbeat_txf_buf; Those are accessed without any kind of synchronization. I do not know exact context, but are you sure it is single-threaded? -- Evgeniy Polyakov