From: Greg KH <gregkh@suse.de>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
virtualization@lists.osdl.org,
Abhishek Kane <v-abkane@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc
Date: Fri, 7 Jan 2011 09:31:39 -0800 [thread overview]
Message-ID: <20110107173139.GA12343@suse.de> (raw)
In-Reply-To: <1294421139-18657-1-git-send-email-hjanssen@microsoft.com>
On Fri, Jan 07, 2011 at 09:25:39AM -0800, Hank Janssen wrote:
> From: Hank Janssen <hjanssen@microsoft.com>
>
> Removed the call to netif_stop_queue() in netvsc_probe() as
> the queue is not initialized at that point and further call
> to it after queue initialization is really not necessary.
>
> This change was prompted after an upstream change went into
> 2.6.37 (netif_tx_stop_queue) that now checks if netif_stop_queue
> is called before register with netdev is done.
>
> This will eliminate the warning message to the log when hv_netvsc
> driver starts up.
>
> Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
What kernel is this needed for, .37? .38? older than .37?
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-07 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 17:25 [PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc Hank Janssen
2011-01-07 17:31 ` Greg KH [this message]
2011-01-07 17:48 ` Hank Janssen
2011-01-07 18:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107173139.GA12343@suse.de \
--to=gregkh@suse.de \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v-abkane@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).