[PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc

[PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc

[Hank Janssen]

From: Hank Janssen <hjanssen@microsoft.com>

Removed the call to netif_stop_queue() in netvsc_probe() as
the queue is not initialized at that point and further call
to it after queue initialization is really not necessary.

This change was prompted after an upstream change went into 
2.6.37 (netif_tx_stop_queue) that now checks if netif_stop_queue
is called before register with netdev is done.

This will eliminate the warning message to the log when hv_netvsc
driver starts up.

Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>


---
 drivers/staging/hv/netvsc_drv.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 0147b40..54706a1 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -358,7 +358,6 @@ static int netvsc_probe(struct device *device)
 
 	/* Set initial state */
 	netif_carrier_off(net);
-	netif_stop_queue(net);
 
 	net_device_ctx = netdev_priv(net);
 	net_device_ctx->device_ctx = device_ctx;
-- 
1.6.0.2

Re: [PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc

[Greg KH]

On Fri, Jan 07, 2011 at 09:25:39AM -0800, Hank Janssen wrote:
> From: Hank Janssen <hjanssen@microsoft.com>
> 
> Removed the call to netif_stop_queue() in netvsc_probe() as
> the queue is not initialized at that point and further call
> to it after queue initialization is really not necessary.
> 
> This change was prompted after an upstream change went into 
> 2.6.37 (netif_tx_stop_queue) that now checks if netif_stop_queue
> is called before register with netdev is done.
> 
> This will eliminate the warning message to the log when hv_netvsc
> driver starts up.
> 
> Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>

What kernel is this needed for, .37?  .38?  older than .37?

thanks,

greg k-h

RE: [PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc

[Hank Janssen]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@suse.de]
> Sent: Friday, January 07, 2011 9:32 AM
> 
> What kernel is this needed for, .37?  .38?  older than .37?
> 
> thanks,
> 
> greg k-h

This is needed for kernels 2.6.37 and newer.

Btw, I have not seen KVP patches that where submitted in linux next yet.
I have not seen any other requests for changes to them, is there anything else needed for acceptance?

Thanks,

Hank.

Re: [PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc

[Greg KH]

On Fri, Jan 07, 2011 at 05:48:11PM +0000, Hank Janssen wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@suse.de]
> > Sent: Friday, January 07, 2011 9:32 AM
> > 
> > What kernel is this needed for, .37?  .38?  older than .37?
> > 
> > thanks,
> > 
> > greg k-h
> 
> This is needed for kernels 2.6.37 and newer.

Ok.

> Btw, I have not seen KVP patches that where submitted in linux next yet.
> I have not seen any other requests for changes to them, is there anything else needed for acceptance?

No, they are in my "to-apply" queue, they missed the deadline for .38,
sorry, due to the holiday break.  I'll queue them up when .38-rc1 is
out.

thanks,

greg k-h