From: Jason Wang <jasowang@redhat.com>
To: virtualization@lists.osdl.org, netdev@vger.kernel.org,
kvm@vger.kernel.org, mst@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop
Date: Mon, 17 Jan 2011 16:10:59 +0800 [thread overview]
Message-ID: <20110117081058.18900.67456.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com> (raw)
No need to check the support of mergeable buffer inside the recevie
loop as the whole handle_rx()_xx is in the read critical region. So
this patch move it ahead of the receiving loop.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/vhost/net.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 14fc189..95e49de 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -411,7 +411,7 @@ static void handle_rx_mergeable(struct vhost_net *net)
};
size_t total_len = 0;
- int err, headcount;
+ int err, headcount, mergeable;
size_t vhost_hlen, sock_hlen;
size_t vhost_len, sock_len;
struct socket *sock = rcu_dereference(vq->private_data);
@@ -425,6 +425,7 @@ static void handle_rx_mergeable(struct vhost_net *net)
vq_log = unlikely(vhost_has_feature(&net->dev, VHOST_F_LOG_ALL)) ?
vq->log : NULL;
+ mergeable = vhost_has_feature(&net->dev, VIRTIO_NET_F_MRG_RXBUF);
while ((sock_len = peek_head_len(sock->sk))) {
sock_len += sock_hlen;
@@ -474,7 +475,7 @@ static void handle_rx_mergeable(struct vhost_net *net)
break;
}
/* TODO: Should check and handle checksum. */
- if (vhost_has_feature(&net->dev, VIRTIO_NET_F_MRG_RXBUF) &&
+ if (likely(mergeable) &&
memcpy_toiovecend(vq->hdr, (unsigned char *)&headcount,
offsetof(typeof(hdr), num_buffers),
sizeof hdr.num_buffers)) {
next reply other threads:[~2011-01-17 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 8:10 Jason Wang [this message]
2011-01-17 8:11 ` [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling Jason Wang
2011-01-17 8:36 ` Michael S. Tsirkin
2011-01-18 3:05 ` Jason Wang
2011-01-18 4:37 ` Michael S. Tsirkin
2011-01-18 7:41 ` Jason Wang
2011-01-17 8:11 ` [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() Jason Wang
2011-01-17 9:33 ` Eric Dumazet
2011-01-17 9:57 ` Michael S. Tsirkin
2011-03-13 15:06 ` Michael S. Tsirkin
2011-03-13 15:52 ` Eric Dumazet
2011-03-13 16:19 ` Michael S. Tsirkin
2011-03-13 16:32 ` Eric Dumazet
2011-03-13 16:43 ` Michael S. Tsirkin
2011-03-13 17:41 ` Eric Dumazet
2011-03-13 21:11 ` Michael S. Tsirkin
2011-01-17 8:46 ` [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop Michael S. Tsirkin
2011-01-18 4:26 ` Jason Wang
2011-01-18 4:36 ` Michael S. Tsirkin
2011-01-18 9:15 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117081058.18900.67456.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).